Merge ~jocave/plainbox-provider-tpm2:update-container-tests into plainbox-provider-tpm2:master

Proposed by Jonathan Cave
Status: Rejected
Rejected by: Sylvain Pineau
Proposed branch: ~jocave/plainbox-provider-tpm2:update-container-tests
Merge into: plainbox-provider-tpm2:master
Diff against target: 28 lines (+6/-9)
1 file modified
requirements/container-tests-provider-tpm2 (+6/-9)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Disapprove
Review via email: mp+359984@code.launchpad.net

Description of the change

Use method of clone dependent providers in to a temporary directory.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Done one master

review: Disapprove

Unmerged commits

11fe34f... by Jonathan Cave

Use new format container tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/requirements/container-tests-provider-tpm2 b/requirements/container-tests-provider-tpm2
2index 93ddb8f..d5d74ad 100755
3--- a/requirements/container-tests-provider-tpm2
4+++ b/requirements/container-tests-provider-tpm2
5@@ -1,17 +1,14 @@
6 #!/bin/bash
7
8-function finish {
9- rm -rf ./plainbox-provider-snappy
10- rm -rf ./plainbox-provider-resource
11-}
12-trap finish EXIT
13+TMPDIR=$(mktemp -d)
14+trap "rm -rf $TMPDIR" EXIT
15
16 set -e
17
18-git clone git://git.launchpad.net/plainbox-provider-resource
19-python3 ./plainbox-provider-resource/manage.py develop --force
20+git clone git://git.launchpad.net/plainbox-provider-resource $TMPDIR/plainbox-provider-resource
21+python3 $TMPDIR/plainbox-provider-resource/manage.py develop --force
22
23-git clone git://git.launchpad.net/plainbox-provider-snappy
24-python3 ./plainbox-provider-snappy/manage.py develop --force
25+git clone git://git.launchpad.net/plainbox-provider-snappy $TMPDIR/plainbox-provider-snappy
26+python3 $TMPDIR/plainbox-provider-snappy/manage.py develop --force
27
28 ./manage.py validate

Subscribers

People subscribed via source and target branches

to all changes: