Code review comment for lp:~jml/testtools/more-doc-improvements

Revision history for this message
Vincent Ladeuil (vila) wrote :

Sphinx generated makefiles become a pita as soon as you need to modify them. Not mentioning doing so after the doc has been translated in several languages, each one requiring its own set of generated makefiles. Been there, found the makefiles, suffered, still searching for a better solution :-( I thought I should mention the problem nevertheless.

365 +<for-test-authors>`, testtools also has many bits and pieces that are useful
366 +for folk who writing testing frameworks.

who *are* writing ?

909 +Python2.7, and that we have no immediate plans it to be so.

*for* it to be so ?

1057 +We highly recommend using the following flags::
1058 +
1059 + doctest.ELLIPSIS | doctest.NORMALIZE_WHITESPACE | doctest.REPORT_NDIFF

Why don't you make them the default flags then ? (Don't answer :)

1239 +the ``Mismatch`` knows how describe a failure to match.

how *to* describe ?

1545 +If you are using a this feature when running your test suite with a legacy
1546 +``TestResult`` object that is missing the ``addSkip`` method, then the

s/a// this feature ?

I don't follow closely (enough :-/) all the parts of testtools, but reading this was a good refresh ;)

review: Approve

« Back to merge proposal