Code review comment for lp:~jml/testresources/adsorb-suite

Revision history for this message
Robert Collins (lifeless) wrote :

On Sun, 2008-11-16 at 21:08 +0000, Jonathan Lange wrote:
> It's hard to articulate.
>
> I think that people who just want to append a test to the suite should be able to do so, rather than having to do something like:
> ots = OptimisingTestSuite()
> ots.addTest(...)
> foo = TestFoo('foo')
> suite = TestSuite([ots, foo])
>
> which achieves the same thing but is more cumbersome.

huh? addTest supports adding a test.

So of:
> ots = OptimisingTestSuite()
> ots.addTest(...)
> foo = TestFoo('foo')
> suite = TestSuite([ots, foo])

The first three lines are boilerplate needed either way; the last line should be
ots.addTest(foo)

no?

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

« Back to merge proposal