Merge lp:~jml/testresources/adsorb-suite into lp:~lifeless/testresources/trunk

[Jonathan Lange]

[Jonathan Lange (jml)]

This branch makes the changes we discussed to adsorbSuite, deprecating it in favour of an addTest method that "distributes" the suite structure.

The more I think about this, the more I think we should have two methods: a regular addTest and a "distributive" addTest. Possible names include: absorbTest, inhaleTest, addTestDistributive, digestTest — basically anything that's not "adbsorb" :)

[lp:~jml/testresources/adsorb-suite]

105. By Jonathan Lange on 2008-10-04

Don't need iterate_tests any more.

106. By Jonathan Lange on 2008-10-29

Merge pyunit3k rename.

[Robert Collins (lifeless)]

Why?

[Robert Collins (lifeless)]

Missing some VWS in CustomSuite.

Other than that, I think this is heading in the right direction. The step that was missed was

'
- All of the tests in each of the resulting new SpecialSuites should have
- identical resource requirements so we can still optimise.
'

This part of the design isn't implemented, and until it is I can see custom suites causing significant resource flapping.

I guess its because of this flapping that you're concerned about this?

Concretely, addTest needs to set 'resources' on each split out CustomSuite, and should only partition the CustomSuite's members when their resource list is not homogeneous.

I hope this is more clear; I think I'd like to hold off merging this until we've done this part, because otherwise it may cause a performance regression.

[Jonathan Lange (jml)]

It's hard to articulate.

I think that people who just want to append a test to the suite should be able to do so, rather than having to do something like:
  ots = OptimisingTestSuite()
  ots.addTest(...)
  foo = TestFoo('foo')
  suite = TestSuite([ots, foo])

which achieves the same thing but is more cumbersome.

[Robert Collins (lifeless)]

On Sun, 2008-11-16 at 21:08 +0000, Jonathan Lange wrote:
> It's hard to articulate.
>
> I think that people who just want to append a test to the suite should be able to do so, rather than having to do something like:
> ots = OptimisingTestSuite()
> ots.addTest(...)
> foo = TestFoo('foo')
> suite = TestSuite([ots, foo])
>
> which achieves the same thing but is more cumbersome.

huh? addTest supports adding a test.

So of:
> ots = OptimisingTestSuite()
> ots.addTest(...)
> foo = TestFoo('foo')
> suite = TestSuite([ots, foo])

The first three lines are boilerplate needed either way; the last line should be
ots.addTest(foo)

no?

-Rob

--
GPG key available at: <http://www.robertcollins.net/keys.txt>.