Code review comment for lp:~jml/pkgme-service/set-debemail

Revision history for this message
James Westby (james-w) wrote :

Hi,

I think I would have done this using the devportal-metadata.json as I find
environment variables to be a little distasteful, but I have no problem with
merging this.

Given that this assumes that the setting is set, I would add it to the main.cfg
so it is always set to start with. I think it has to be added to the configglue
schema as well.

Thanks,

James

review: Approve

« Back to merge proposal