Merge lp:~jml/pkgme-service/set-debemail into lp:pkgme-service
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Jonathan Lange | ||||
Proposed branch: | lp:~jml/pkgme-service/set-debemail | ||||
Merge into: | lp:pkgme-service | ||||
Diff against target: |
94 lines (+37/-3) 4 files modified
django_project/schema.py (+1/-0) src/djpkgme/tasks.py (+6/-2) src/djpkgme/tests/test_integration.py (+0/-1) src/djpkgme/tests/test_tasks.py (+30/-0) |
||||
To merge this branch: | bzr merge lp:~jml/pkgme-service/set-debemail | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby (community) | Approve | ||
Review via email: mp+99305@code.launchpad.net |
Commit message
Set the DEBEMAIL based on a configuration setting.
Description of the change
This branch adds a config field called PKGME_MAINTAINE
This in turn causes pkgme to use PKGME_MAINTAINE
I haven't updated any configs because I'm not exactly sure which ones to update. We'll want to set the production value to the email address of https:/
Unmerged revisions
- 80. By Jonathan Lange
-
Add a setting PKGME_MAINTAINE
R_EMAIL and use that to set the maintainer
for packages made by pkgme.
Hi,
I think I would have done this using the devportal- metadata. json as I find
environment variables to be a little distasteful, but I have no problem with
merging this.
Given that this assumes that the setting is set, I would add it to the main.cfg
so it is always set to start with. I think it has to be added to the configglue
schema as well.
Thanks,
James