Merge lp:~jml/pkgme/default-maintainer into lp:pkgme

[Jonathan Lange]

Use DEBEMAIL environment variable to set the package maintainer.

This changes the Maintainer field to use the DEBEMAIL environment variable if it's set. Otherwise, uses the dummy "A Person" email address that pkgme currently uses.

The goal of this change is to allow pkgme-service to specify the maintainer for the packages that it builds.

[Jonathan Lange (jml)]

Note that the python_debian on my precise system seems to have a get_maintainer() function that we could & probably should use, but that this function is not available in my pkgme virtualenv.

[James Westby (james-w)]

The algorithm for DEBEMAIL and friends is more complex than this, but I think
this is an ok start. Using the get_maintainer() function at a later date would
be good.

Thanks,

James

review: Approve

=== modified file 'pkgme/info_elements.py'
--- pkgme/info_elements.py	2012-02-04 18:29:54 +0000
+++ pkgme/info_elements.py	2012-03-26 12:00:45 +0000
@@ -1,5 +1,6 @@
 import json
 import re
+import os
 
 
 class InvalidInfoError(Exception):
@@ -104,8 +105,13 @@
         Name <email>
 
     """
+
     default = "A Person <[e-mail]>"
 
+    @classmethod
+    def get_default(cls):
+        return os.environ.get('DEBEMAIL', cls.default)
+
 
 class Homepage(InfoElement):
 

=== modified file 'pkgme/tests/test_info_elements.py'
--- pkgme/tests/test_info_elements.py	2012-02-04 18:29:54 +0000
+++ pkgme/tests/test_info_elements.py	2012-03-26 12:00:45 +0000
@@ -1,5 +1,6 @@
 import json
 
+from fixtures import EnvironmentVariableFixture
 from testtools import TestCase
 
 from pkgme.info_elements import (
@@ -10,6 +11,7 @@
     ExtraFilesFromPaths,
     InfoElement,
     InvalidInfoError,
+    Maintainer,
     MissingInfoError,
     PackageName,
     )
@@ -265,6 +267,19 @@
  more information""", cleaned)
 
 
+class TestMaintainer(TestCase):
+
+    def test_unspecified(self):
+        self.useFixture(EnvironmentVariableFixture('DEBEMAIL', None))
+        self.assertEqual(
+            Maintainer.default, Maintainer.get_value(DictInfo({})))
+
+    def test_from_environment_variable(self):
+        debemail = 'Dude <[e-mail]>'
+        self.useFixture(EnvironmentVariableFixture('DEBEMAIL', debemail))
+        self.assertEqual(debemail, Maintainer.get_value(DictInfo({})))
+
+
 class TestPackageName(TestCase):
 
     def test_valid(self):