Merge lp:~jml/launchpadlib/add-stable-bug-418316 into lp:launchpadlib
Proposed by
Jonathan Lange
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Francis J. Lacoste | ||||
Approved revision: | 42 | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~jml/launchpadlib/add-stable-bug-418316 | ||||
Merge into: | lp:launchpadlib | ||||
Diff against target: | None lines | ||||
To merge this branch: | bzr merge lp:~jml/launchpadlib/add-stable-bug-418316 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis J. Lacoste (community) | Approve | ||
Review via email: mp+10706@code.launchpad.net |
To post a comment you must log in.
This branch adds a constant for the Launchpad production API service.
There are three things I'm not sure about:
1. What should the name of the variable be? I've picked LPNET_SERVICE_ROOT.
2. What should the URL be? I've picked https:/ /api.launchpad. net/beta/
3. When I tested it manually, my browser opened the authorization window on the edge server. Presumably this is because of automatic redirection. It seemed weird enough to hesitate though.
It's a small patch, so I'd appreciate a swift review.