Code review comment for lp:~jml/launchpadlib/add-stable-bug-418316

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

On August 25, 2009, Jonathan Lange wrote:
> Jonathan Lange has proposed merging
> lp:~jml/launchpadlib/add-stable-bug-418316 into lp:launchpadlib.
>
> Requested reviews:
> LAZR Developers (lazr-developers)
>
> This branch adds a constant for the Launchpad production API service.
>
> There are three things I'm not sure about:
>
> 1. What should the name of the variable be? I've picked
> LPNET_SERVICE_ROOT.
>

That's fine.

> 2. What should the URL be? I've picked https://api.launchpad.net/beta/

That's also the correct URL.

>
> 3. When I tested it manually, my browser opened the authorization window
> on the edge server. Presumably this is because of automatic redirection. It
> seemed weird enough to hesitate though.
>

It is because of the redirection code. Your approval would still be honoured
since it's the same DB.

  status approved
  review approve

Thanks for fixing this!

--
Francis J. Lacoste
<email address hidden>

review: Approve

« Back to merge proposal