Merge lp:~jml/launchpadlib/add-stable-bug-418316 into lp:launchpadlib

[Jonathan Lange]

[Jonathan Lange (jml)]

This branch adds a constant for the Launchpad production API service.

There are three things I'm not sure about:

  1. What should the name of the variable be? I've picked LPNET_SERVICE_ROOT.

  2. What should the URL be? I've picked https://api.launchpad.net/beta/

  3. When I tested it manually, my browser opened the authorization window on the edge server. Presumably this is because of automatic redirection. It seemed weird enough to hesitate though.

It's a small patch, so I'd appreciate a swift review.

[Francis J. Lacoste (flacoste)]

On August 25, 2009, Jonathan Lange wrote:
> Jonathan Lange has proposed merging
> lp:~jml/launchpadlib/add-stable-bug-418316 into lp:launchpadlib.
>
> Requested reviews:
> LAZR Developers (lazr-developers)
>
> This branch adds a constant for the Launchpad production API service.
>
> There are three things I'm not sure about:
>
> 1. What should the name of the variable be? I've picked
> LPNET_SERVICE_ROOT.
>

That's fine.

> 2. What should the URL be? I've picked https://api.launchpad.net/beta/

That's also the correct URL.

>
> 3. When I tested it manually, my browser opened the authorization window
> on the edge server. Presumably this is because of automatic redirection. It
> seemed weird enough to hesitate though.
>

It is because of the redirection code. Your approval would still be honoured
since it's the same DB.

  status approved
  review approve

Thanks for fixing this!

--
Francis J. Lacoste
<email address hidden>

review: Approve

=== modified file 'src/launchpadlib/launchpad.py'
--- src/launchpadlib/launchpad.py	2009-03-23 21:50:35 +0000
+++ src/launchpadlib/launchpad.py	2009-08-26 00:17:09 +0000
@@ -39,6 +39,7 @@
 
 STAGING_SERVICE_ROOT = 'https://api.staging.launchpad.net/beta/'
 EDGE_SERVICE_ROOT = 'https://api.edge.launchpad.net/beta/'
+LPNET_SERVICE_ROOT = 'https://api.launchpad.net/beta/'
 
 class Launchpad(Resource):
     """Root Launchpad API class.