Code review comment for lp:~jelmer/launchpad/607677-grey-disabled-archives

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Great - thanks Jelmer. The only thing that looks a little strange is the link (the fact that it's still blue). I don't know if we have a standard for displaying links for disable items, but:

https://edge.launchpad.net/~michael.nelson

shows a linked disabled PPA which is grey. The problem with the grey is that it's not obviously a link, which in the case of a row of data is much more of a problem. So I'm approving this as is, but just noting that we need to define guidelines for linking to disabled objects (I'll chat with Curtis later).

review: Approve (ui)

« Back to merge proposal