Merge lp:~jelmer/launchpad/607677-grey-disabled-archives into lp:launchpad

[Jelmer Vernooij]

Grey out disabled archives in the per-distribution copy archive list.

This simple change greys out disabled archives in the per-distribution copy archive list.

An example of how it looks can be found at http://people.canonical.com/~jelmer/screenshot-disabled-archives.png

[Robert Collins (lifeless)]

Looks ok to me, fwiw.

review: Approve

[Michael Nelson (michael.nelson)]

Great - thanks Jelmer. The only thing that looks a little strange is the link (the fact that it's still blue). I don't know if we have a standard for displaying links for disable items, but:

https://edge.launchpad.net/~michael.nelson

shows a linked disabled PPA which is grey. The problem with the grey is that it's not obviously a link, which in the case of a row of data is much more of a problem. So I'm approving this as is, but just noting that we need to define guidelines for linking to disabled objects (I'll chat with Curtis later).

review: Approve (ui)

=== modified file 'lib/lp/soyuz/templates/distribution-archive-list.pt'
--- lib/lp/soyuz/templates/distribution-archive-list.pt	2009-08-13 14:00:06 +0000
+++ lib/lp/soyuz/templates/distribution-archive-list.pt	2010-07-22 09:51:10 +0000
@@ -37,7 +37,8 @@
         </thead>
         <tbody>
           <tal:batch_repeat repeat="archive batch">
-            <tr tal:define="build_counts archive/getBuildCounters">
+          <tr tal:attributes="class python:not archive.enabled and 'greyed-out'"
+              tal:define="build_counts archive/getBuildCounters">
               <td tal:content="archive/date_created/fmt:approximatedate" />
               <td>
                 <a tal:attributes="href archive/fmt:url"