Merge lp:~jelmer/launchpad-buildd/dpkg-buildpackage-sa into lp:launchpad-buildd
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | 26 |
Merged at revision: | 26 |
Proposed branch: | lp:~jelmer/launchpad-buildd/dpkg-buildpackage-sa |
Merge into: | lp:launchpad-buildd |
Diff against target: |
25 lines (+4/-1) 2 files modified
buildrecipe (+2/-1) debian/changelog (+2/-0) |
To merge this branch: | bzr merge lp:~jelmer/launchpad-buildd/dpkg-buildpackage-sa |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+82623@code.launchpad.net |
Description of the change
Unconditionally include the orig tarball with a recipe build source upload.
By default, dpkg-buildpackage looks at the changelog and checks if there were older entries with the same upstream version beyond the current version [1]. If it finds older entries with the same upstream version, it doesn't bother including the orig tarball again - presumably because the archive already has it.
The -sa argument overrides this behaviour and makes dpkg-source always include the orig tarballs.
This makes it easier to upload recipe builds to PPAs even if there are previous entries in the same changelog that haven't been uploaded to that PPA.
[1] technically, beyond what is in the .changes file - but buildrecipe doesn't use -v.
This looks good... couldn't including the source sometimes cause the
ppa upload to be rejected though, if that tarball is already present?
Or I guess ppas will tolerate that as long as the contents are the
same.
It may fail but probably less often.