Merge lp:~jelmer/bzr-cvsps-import/avoid-note into lp:bzr-cvsps-import

Proposed by Jelmer Vernooij
Status: Merged
Approved by: John A Meinel
Approved revision: 68
Merged at revision: 68
Proposed branch: lp:~jelmer/bzr-cvsps-import/avoid-note
Merge into: lp:bzr-cvsps-import
Diff against target: 34 lines (+4/-3)
2 files modified
cvsps/importer.py (+1/-2)
cvsps/parser.py (+3/-1)
To merge this branch: bzr merge lp:~jelmer/bzr-cvsps-import/avoid-note
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+54749@code.launchpad.net

Description of the change

Avoid ProgressTask.note, which no longer exists.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/24/2011 06:53 PM, Jelmer Vernooij wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-cvsps-import/avoid-note into lp:bzr-cvsps-import.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr-cvsps-import/avoid-note/+merge/54749
>
> Avoid ProgressTask.note, which no longer exists.

 merge: approve
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2LmLYACgkQJdeBCYSNAAOZGACgyFjgc1NxCn5812wFrpHIP31q
SvIAn31OW/u6Fm2RZtmMf/ntH+NlPKRc
=UNFo
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cvsps/importer.py'
--- cvsps/importer.py 2011-02-27 22:45:04 +0000
+++ cvsps/importer.py 2011-03-24 17:55:30 +0000
@@ -1217,8 +1217,7 @@
1217 else:1217 else:
1218 cvsps_dump_path = osutils.pathjoin(self._staging_path,1218 cvsps_dump_path = osutils.pathjoin(self._staging_path,
1219 self._module_fname + '.dump')1219 self._module_fname + '.dump')
1220 if pb is not None:1220 trace.note('Creating cvsps dump file: %s', cvsps_dump_path)
1221 pb.note('Creating cvsps dump file: %s', cvsps_dump_path)
1222 # Create a dump file1221 # Create a dump file
1223 cvsps_controller = CVSPSController(cvs_root=self._cvs_root,1222 cvsps_controller = CVSPSController(cvs_root=self._cvs_root,
1224 cvs_module=self._cvs_module)1223 cvs_module=self._cvs_module)
12251224
=== modified file 'cvsps/parser.py'
--- cvsps/parser.py 2011-02-24 00:19:59 +0000
+++ cvsps/parser.py 2011-03-24 17:55:30 +0000
@@ -16,6 +16,8 @@
1616
17"""The functionality for parsing a cvsps dump file"""17"""The functionality for parsing a cvsps dump file"""
1818
19from bzrlib import trace
20
19import calendar21import calendar
20import time22import time
2123
@@ -268,7 +270,7 @@
268 if self._pb is not None:270 if self._pb is not None:
269 self._pb.update('reading patchsets', 0, len(self._patchsets))271 self._pb.update('reading patchsets', 0, len(self._patchsets))
270272
271 self._pb.note('Read %s patchsets (string cache hits: %s, total: %s)',273 trace.note('Read %s patchsets (string cache hits: %s, total: %s)',
272 len(self._patchsets), self._cache_hits,274 len(self._patchsets), self._cache_hits,
273 len(self._string_cache))275 len(self._string_cache))
274276

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: