Merge lp:~jelmer/bzr-cvsps-import/avoid-note into lp:bzr-cvsps-import

Proposed by Jelmer Vernooij
Status: Merged
Approved by: John A Meinel
Approved revision: 68
Merged at revision: 68
Proposed branch: lp:~jelmer/bzr-cvsps-import/avoid-note
Merge into: lp:bzr-cvsps-import
Diff against target: 34 lines (+4/-3)
2 files modified
cvsps/importer.py (+1/-2)
cvsps/parser.py (+3/-1)
To merge this branch: bzr merge lp:~jelmer/bzr-cvsps-import/avoid-note
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+54749@code.launchpad.net

Description of the change

Avoid ProgressTask.note, which no longer exists.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/24/2011 06:53 PM, Jelmer Vernooij wrote:
> Jelmer Vernooij has proposed merging lp:~jelmer/bzr-cvsps-import/avoid-note into lp:bzr-cvsps-import.
>
> Requested reviews:
> Bazaar Developers (bzr)
>
> For more details, see:
> https://code.launchpad.net/~jelmer/bzr-cvsps-import/avoid-note/+merge/54749
>
> Avoid ProgressTask.note, which no longer exists.

 merge: approve
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2LmLYACgkQJdeBCYSNAAOZGACgyFjgc1NxCn5812wFrpHIP31q
SvIAn31OW/u6Fm2RZtmMf/ntH+NlPKRc
=UNFo
-----END PGP SIGNATURE-----

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cvsps/importer.py'
2--- cvsps/importer.py 2011-02-27 22:45:04 +0000
3+++ cvsps/importer.py 2011-03-24 17:55:30 +0000
4@@ -1217,8 +1217,7 @@
5 else:
6 cvsps_dump_path = osutils.pathjoin(self._staging_path,
7 self._module_fname + '.dump')
8- if pb is not None:
9- pb.note('Creating cvsps dump file: %s', cvsps_dump_path)
10+ trace.note('Creating cvsps dump file: %s', cvsps_dump_path)
11 # Create a dump file
12 cvsps_controller = CVSPSController(cvs_root=self._cvs_root,
13 cvs_module=self._cvs_module)
14
15=== modified file 'cvsps/parser.py'
16--- cvsps/parser.py 2011-02-24 00:19:59 +0000
17+++ cvsps/parser.py 2011-03-24 17:55:30 +0000
18@@ -16,6 +16,8 @@
19
20 """The functionality for parsing a cvsps dump file"""
21
22+from bzrlib import trace
23+
24 import calendar
25 import time
26
27@@ -268,7 +270,7 @@
28 if self._pb is not None:
29 self._pb.update('reading patchsets', 0, len(self._patchsets))
30
31- self._pb.note('Read %s patchsets (string cache hits: %s, total: %s)',
32+ trace.note('Read %s patchsets (string cache hits: %s, total: %s)',
33 len(self._patchsets), self._cache_hits,
34 len(self._string_cache))
35

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: