Merge lp:~jcsackett/launchpad/target-adapters-aplenty into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Graham Binns |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13840 |
Proposed branch: | lp:~jcsackett/launchpad/target-adapters-aplenty |
Merge into: | lp:launchpad |
Diff against target: |
195 lines (+122/-18) 3 files modified
lib/lp/app/browser/configure.zcml (+8/-0) lib/lp/app/browser/tests/test_vocabulary.py (+65/-0) lib/lp/app/browser/vocabulary.py (+49/-18) |
To merge this branch: | bzr merge lp:~jcsackett/launchpad/target-adapters-aplenty |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+73248@code.launchpad.net |
Commit message
[r=gmb][bug=820005][incr] Creates new base adapter for targets for target pickers.
Description of the change
Summary
=======
This branch introduces a new base TargetPickerSource adapter to adapt targets (DistributionSo
Preimplementation
=================
Spoke with Curtis Hovey.
Implementation
==============
lib/lp/
lib/lp/
-------
Created new base adapter, created product and distro adapters derived from new base, and updated the dsp adapter from the new base.
lib/lp/
-------
Added tests.
Tests
=====
bin/test -vvct test_vocabulary
QA
==
None, this is a refactor and new parts aren't effectively bolted in to any new pickers.
Lint
====
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
389: E251 no spaces around keyword / parameter equals