Code review comment for lp:~jcsackett/launchpad/broken-help-link

Revision history for this message
Curtis Hovey (sinzui) wrote :

On Tue, 2010-08-17 at 08:36 +0000, Henning Eggers wrote:
> Wow, thanks for fixing this so quickly!
>
> I am surprised, though, that so much has to be done in TAL to achieve
> this. This looks like a fairly common task (switch to a different
> vhost) that I'd hope we have short cuts for it. Is there a bug for
> this or should I file one?

1. the official link in the overview menu did not work because stupid
menus always make links for the host they are one. This seems to
contradict the intent of putting a menu on a facet. eg:
object/menu:overview/downloads

2. The tales fmt/link:mainsite did not work because the menu
pregenerated the URL eg:
object/menu:overview/downloads/fmt:link:mainsite

I am sending a email about this and other menu problems later today.

--
__Curtis C. Hovey_________
http://launchpad.net/

« Back to merge proposal