Merge lp:~jcsackett/launchpad/broken-help-link into lp:launchpad

[j.c.sackett]

Changes a download link on the template to point to the correct page on http://launchpad.net instead of code.launchpad.net. Previously the help link was broken b/c the initial download file link was on the wrong host.

Summary

Fixes a broken help link by buildling a correct link for +download on a product.

Proposed fix

We thought it might be possible to use the menu to create a link to the right page on the right host, but the menu doesn't behave as expected; instead we looked into using a better hand crafted url.

Pre-implementation notes

Spoke with Curtis Hovey (sinzui) to investigate the use of a menu for the link, where we discovered that the menu didn't behave as expected with respect to rootsite definitions.

Implementation details

A link on the product-branch-summary template was updated to point to +download on the mainsite instead of on code. This page is the same page, but as a result the broken help link renders correctly.

Demo and Q/A

Go to http://code.launchpad.dev/firefox and follow the link for downloads. You should end up on http://launchpad.dev/firefox/+download, not http://code.launchpad.dev/firefox/+dev. The help link referenced in the bug should now work.

lint
= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/code/stories/branches/xx-product-branches.txt
  lib/lp/code/templates/product-branch-summary.pt

[Curtis Hovey (sinzui)]

This looks good to land

review: Approve (code)

[Henning Eggers (henninge)]

Wow, thanks for fixing this so quickly!

I am surprised, though, that so much has to be done in TAL to achieve this. This looks like a fairly common task (switch to a different vhost) that I'd hope we have short cuts for it. Is there a bug for this or should I file one?

[Curtis Hovey (sinzui)]

On Tue, 2010-08-17 at 08:36 +0000, Henning Eggers wrote:
> Wow, thanks for fixing this so quickly!
>
> I am surprised, though, that so much has to be done in TAL to achieve
> this. This looks like a fairly common task (switch to a different
> vhost) that I'd hope we have short cuts for it. Is there a bug for
> this or should I file one?

1. the official link in the overview menu did not work because stupid
menus always make links for the host they are one. This seems to
contradict the intent of putting a menu on a facet. eg:
object/menu:overview/downloads

2. The tales fmt/link:mainsite did not work because the menu
pregenerated the URL eg:
object/menu:overview/downloads/fmt:link:mainsite

I am sending a email about this and other menu problems later today.

--
__Curtis C. Hovey_________
http://launchpad.net/

=== modified file 'lib/lp/code/stories/branches/xx-product-branches.txt'
--- lib/lp/code/stories/branches/xx-product-branches.txt	2010-06-28 14:00:17 +0000
+++ lib/lp/code/stories/branches/xx-product-branches.txt	2010-08-16 16:58:46 +0000
@@ -66,6 +66,9 @@
     There are no branches for NetApplet in Launchpad.
     ...
     There are download files available for NetApplet.
+    >>> browser.getLink('download files')
+    <Link...url='http://launchpad.dev/netapplet/+download'>
+
 
 
 Development focus branches

=== modified file 'lib/lp/code/templates/product-branch-summary.pt'
--- lib/lp/code/templates/product-branch-summary.pt	2010-06-25 17:40:07 +0000
+++ lib/lp/code/templates/product-branch-summary.pt	2010-08-16 16:58:46 +0000
@@ -60,9 +60,10 @@
     </div>
 
   </tal:has-branches>
-
   <p tal:condition="view/latest_release_with_download_files">
-    <img src="/@@/download"/> There are <a href="+download">download files</a>
+    <img src="/@@/download"/> There are
+    <a tal:define="rooturl modules/canonical.launchpad.webapp.vhosts/allvhosts/configs/mainsite/rooturl"
+      tal:attributes="href string:${rooturl}${context/name}/+download">download files</a>
     available for <tal:project-name replace="context/displayname"/>.
   </p>