Code review comment for lp:~jcsackett/juju-gui/scroll-to-top-on-change

On 2013/05/01 18:49:23, j.c.sackett wrote:

https://codereview.appspot.com/9088043/diff/1/app/subapps/browser/views/charm.js
> File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/9088043/diff/1/app/subapps/browser/views/charm.js#newcode465
> app/subapps/browser/views/charm.js:465: var viewData =
Y.one('.bws-view-data');
> On 2013/05/01 17:50:06, rharding wrote:
> > I'm assuming this is changed because the valueFn was grabbing before
the node
> > was there? Can we change renderTo to work with the getter then and
prevent
> hard
> > coding the Y.one here? The renderTo was updated to keep all the
views in
> common
> > and for testing. This happens to work because you're using the
default value
> > anyway.

> Actually, when I started this line was
> Y.one('.bws-view-data').setHTML(tplNode); I think this is a bad
merge--I'm
> totally happy to use renderTo. I've made that change and everything
works.

Ah, thanks for the follow up. Never mind then.

https://codereview.appspot.com/9088043/