lp:~jcsackett/juju-gui/scroll-to-top-on-change

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 634

Juju GUI Hackers: Pending requested 2013-05-01

Diff: 62 lines (+13/-3)

3 files modified

app/subapps/browser/views/charm.js (+7/-2)
app/subapps/browser/views/editorial.js (+1/-1)
app/subapps/browser/views/search.js (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1174376: Search results should appear with top result visible	Medium	Fix Released
Bug #1174392: Charm details view doesn't render at top of scrollable portion	High	Fix Released

Link a bug report

Related blueprints

634. By j.c.sackett on 2013-05-01

Make comments on scrollIntoView calls XXX comments.

633. By j.c.sackett on 2013-05-01

renderTo instead of viewData

632. By j.c.sackett on 2013-05-01

Merged trunk, resolving conflicts.

631. By j.c.sackett on 2013-05-01

Comments.

630. By j.c.sackett on 2013-05-01

Link charm details bug.

629. By j.c.sackett on 2013-05-01

Link search results bug.

628. By j.c.sackett on 2013-05-01

Add scrollIntoView on top elements in views that are loading partway down.

627. By j.c.sackett on 2013-04-30

Editorial error message shouldn't say 'sidebar'

626. By Richard Harding on 2013-04-30

TRIVIAL - google fonts over https

- One letter diff ftw.

R=
CC=
https://codereview.appspot.com/9046043

625. By Richard Harding on 2013-04-29

Adds filter controls to the search in the browser

- The branch updates the models/browser.js Filter model that is basically the
search state in the application.
- The subapp keeps an instance of that around and updates it along with the
rest of the subapplication state.
- The subapp passes the raw data down into views that can use it to populate
the search related widgets (search and filters).
- When those widgets are changed they trigger a custom event back up to their
controlling View.
- That View then generates a change event to the subapp directing it to update
it's current _filter (the Filter model) with that change and navigate to the
new url.
- All searches are url-able and thus force a navigate and re-process through
the render chain.
- Because of this, the Views do not need to update their version of the
filters, they'll get new ones from the subapp on the next routing.

Known QA issues:

- There's not a good "no results found" display
- There's not a list of selected filters per UX design when the filter list is
collapsed in sidebar view
- Theme'ing needs to be done on the filter list to remove the leading *, make
things more header-like, add proper arrows vs temp ^/v
- It's felt these are correctable through the week while the functionality is
able to be added before 'feature freeze' on Monday.

R=j.c.sackett, benji
CC=
https://codereview.appspot.com/9003043