Code review comment for lp:~jcsackett/juju-gui/abstract-default-viewmode

Revision history for this message
j.c.sackett (jcsackett) wrote :

On 2013/07/02 15:13:15, jeff.pihach wrote:
> LGTM'd thanks for this improvement!

> As mentioned in IRC - next step being able to be set via the config.js
files.

https://codereview.appspot.com/10870043/diff/7001/test/test_browser_app.js
> File test/test_browser_app.js (right):

https://codereview.appspot.com/10870043/diff/7001/test/test_browser_app.js#newcode245
> test/test_browser_app.js:245: it('* route uses the default viewmode',
function()
> {
> it('routes * by using the default viewmode' ...

> PTDD (pedantic tdd) ;-)

I think that's probably pedantic bdd. :-P I've fixed it.

https://codereview.appspot.com/10870043/

« Back to merge proposal