lp:~jcsackett/juju-gui/abstract-default-viewmode

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:juju-gui/experimental at revision 795

Juju GUI Hackers: Pending requested 2013-07-02

Diff: 175 lines (+47/-19)

2 files modified

app/subapps/browser/browser.js (+26/-12)
test/test_browser_app.js (+21/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

790. By j.c.sackett on 2013-07-03

Merged colo:trunk

789. By j.c.sackett on 2013-07-02

camelCase

788. By j.c.sackett on 2013-07-02

Shut up, lint.

787. By j.c.sackett on 2013-07-02

Shut up, lint

786. By j.c.sackett on 2013-07-02

Merged trunk.

785. By j.c.sackett on 2013-07-01

Test shows fullscreen works too.

784. By j.c.sackett on 2013-07-01

We use defaults now, not sidebar

783. By Jeff Pihach on 2013-06-28

Fixes DD test failure in FF

R=benji
CC=
https://codereview.appspot.com/10769043

782. By Benji York on 2013-06-28

Fine tune the charm token drag and drop.

- change the drag token to be the charm icon
- make the service ghost appear where the user dropped the charm icon
- fix browser wierdness around dragImage elements
- tweak the way the tests set the charm token container

R=matthew.scott, jeff.pihach
CC=
https://codereview.appspot.com/10763043

781. By Richard Harding on 2013-06-28

Update makefile template and css build targets.

- The template targets didn't take into account the subapps directory.
- There was no direct target watching css files. Since they're built as part
of the templates I think it's typical for a template change to accompany css
changes and it wasn't noticed there was a corner case.

QA
--

To QA you need to run `make build-prod`. Once that is done, run it again and
see that it does not rerun any builders on the template/css targets.

Then, touch a template in the subapps directory and make build-prod again.

`touch app/subapps/browser/templates/minimized.handlebars && make build-prod`

Run build-prod again and see that there's no change. Then touch a less file
and verify the makefile catches it as changed and rebuilds.

`touch lib/views/browser/charm-token.less && make build-prod`

R=j.c.sackett, benji
CC=
https://codereview.appspot.com/10756043