Code review comment for lp:~jbicha/ubiquity/fix-missing-icon-in-gnome-shell

Revision history for this message
Jeremy BĂ­cha (jbicha) wrote :

Dmitrijs, thanks for the review and apologies for the diff being so large. Next time I'll have to try to split a change like this into smaller merge proposals.

I've remerged my changes against trunk and the debdiff output should be a lot cleaner now. ubiquity-kde's icon is called ubiquity-kde (which is much saner than trying to use the same name as ubiquity). ubiquity includes several icon sizes now, stored in the usual hicolor location instead of in pixmaps.

There's still an extra /usr/share/ubiquity/gtk/nm.xml which I guess might be needed if editing the Wireless screen in glade. It takes up almost no space but we could remove it in debian/rules if we really didn't want it.

« Back to merge proposal