Code review comment for lp:~jbicha/ubiquity/fix-missing-icon-in-gnome-shell

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

I see a significant debdiff on ubiquity-frontend-kde & ubiquity-frontend-gtk packages. Can you take a look, and check if that's intentional? As far as I can tell, ubiquity-dm on gtk is broken with panel missing.

$ debdiff ubiquity-frontend-kde_2.15.9_all.deb ubiquity-frontend-kde_2.15.10_all.deb
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rw-r--r-- root/root /usr/share/icons/hicolor/128x128/apps/ubiquity-kde.png
-rw-r--r-- root/root /usr/share/icons/hicolor/16x16/apps/ubiquity-kde.png
-rw-r--r-- root/root /usr/share/icons/hicolor/22x22/apps/ubiquity-kde.png
-rw-r--r-- root/root /usr/share/icons/hicolor/32x32/apps/ubiquity-kde.png
-rw-r--r-- root/root /usr/share/icons/hicolor/48x48/apps/ubiquity-kde.png
-rw-r--r-- root/root /usr/share/icons/hicolor/64x64/apps/ubiquity-kde.png
-rw-r--r-- root/root /usr/share/ubiquity/qt/images/background.xcf
-rw-r--r-- root/root /usr/share/ubiquity/qt/images/graphics.svg
-rw-r--r-- root/root /usr/share/ubiquity/qt/images/try-install.svg
-rwxr-xr-x root/root /usr/share/ubiquity/qt/images/genrtl.py

Files in first .deb but not in second
-------------------------------------
-rw-r--r-- root/root /usr/share/icons/hicolor/128x128/apps/ubiquity.png
-rw-r--r-- root/root /usr/share/icons/hicolor/16x16/apps/ubiquity.png
-rw-r--r-- root/root /usr/share/icons/hicolor/22x22/apps/ubiquity.png
-rw-r--r-- root/root /usr/share/icons/hicolor/32x32/apps/ubiquity.png
-rw-r--r-- root/root /usr/share/icons/hicolor/48x48/apps/ubiquity.png
-rw-r--r-- root/root /usr/share/icons/hicolor/64x64/apps/ubiquity.png

Control files: lines which differ (wdiff format)
------------------------------------------------
Depends: python3 (>= 3.2.3-3~), ubiquity (= [-2.15.9),-] {+2.15.10),+} python3-pyqt4, kde-window-manager, xauth, python3-dbus, python3-dbus.mainloop.qt
Installed-Size: [-933-] {+1958+}
Provides: [-ubiquity-frontend-2.15.9-] {+ubiquity-frontend-2.15.10+}
Version: [-2.15.9-] {+2.15.10+}

$ debdiff ubiquity-frontend-gtk_2.15.9_amd64.deb ubiquity-frontend-gtk_2.15.10_amd64.deb
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rw-r--r-- root/root /usr/share/icons/hicolor/16x16/apps/ubiquity.svg
-rw-r--r-- root/root /usr/share/icons/hicolor/22x22/apps/ubiquity.svg
-rw-r--r-- root/root /usr/share/icons/hicolor/24x24/apps/ubiquity.svg
-rw-r--r-- root/root /usr/share/icons/hicolor/32x32/apps/ubiquity.svg
-rw-r--r-- root/root /usr/share/icons/hicolor/48x48/apps/ubiquity.svg
-rw-r--r-- root/root /usr/share/icons/hicolor/64x64/apps/ubiquity.svg
-rw-r--r-- root/root /usr/share/ubiquity/gtk/nm.xml
-rw-r--r-- root/root /usr/share/ubiquity/pixmaps/u1/assets/TODO
-rw-r--r-- root/root /usr/share/ubiquity/pixmaps/u1/assets/active_bevel.png
-rw-r--r-- root/root /usr/share/ubiquity/pixmaps/u1/assets/active_gradience.png
-rw-r--r-- root/root /usr/share/ubiquity/pixmaps/u1/assets/active_stroke.png
-rw-r--r-- root/root /usr/share/ubiquity/pixmaps/u1/assets/deactive_bevel.png
-rw-r--r-- root/root /usr/share/ubiquity/pixmaps/u1/assets/deactive_colour.png
-rw-r--r-- root/root /usr/share/ubiquity/pixmaps/u1/ubuntu_one_logo.png

Files in first .deb but not in second
-------------------------------------
-rw-r--r-- root/root /usr/share/gir-1.0/UbiquityMockResolver-1.0.gir
-rw-r--r-- root/root /usr/share/locale/am/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ar/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ast/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/be/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/bg/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/bn/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/bs/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ca/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/cs/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/da/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/de/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/el/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/eo/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/es/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/et/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/eu/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/fi/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/fr/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ga/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/gl/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/gu/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/he/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/hi/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/hr/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/hu/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/id/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/it/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ja/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ka/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/kk/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/km/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ko/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ku/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/lt/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/lv/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/mk/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ml/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/mr/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ne/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/nl/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/pa/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/pl/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/pt/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/pt_BR/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ro/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ru/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/sk/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/sl/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/sq/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/sr/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/sv/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/ta/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/th/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/tl/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/tr/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/uk/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/vi/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/zh_CN/LC_MESSAGES/ubiquity.mo
-rw-r--r-- root/root /usr/share/locale/zh_TW/LC_MESSAGES/ubiquity.mo
-rwxr-xr-x root/root /usr/lib/ubiquity/panel
-rwxr-xr-x root/root /usr/lib/ubiquity/wallpaper

Control files: lines which differ (wdiff format)
------------------------------------------------
Depends: libc6 (>= 2.2.5), [-libcairo2 (>= 1.2.4), libgdk-pixbuf2.0-0 (>= 2.22.0),-] libglib2.0-0 (>= 2.37.3), [-libgtk-3-0 (>= 3.0.0), libindicator3-7 (>= 0.4.90), libx11-6,-] python3 (>= 3.2.3-3~), ubiquity (= [-2.15.9),-] {+2.15.10),+} python3-dbus, gir1.2-gtk-3.0, gir1.2-soup-2.4, gir1.2-vte-2.90, gir1.2-webkit-3.0, iso-codes, metacity | xfwm4 | matchbox-window-manager | lubuntu-default-settings | openbox, gir1.2-xkl-1.0, gir1.2-timezonemap-1.0, gir1.2-gnomekeyring-1.0, python3-gi, python3-cairo, python3-gi-cairo, gir1.2-appindicator3-0.1, python3-oauthlib, busybox-static | busybox
Installed-Size: [-1199-] {+1339+}
Provides: indicator-renderer, [-ubiquity-frontend-2.15.9-] {+ubiquity-frontend-2.15.10+}
Version: [-2.15.9-] {+2.15.10+}

review: Needs Fixing

« Back to merge proposal