Code review comment for lp:~jaypipes/glance/glance-cli-tool
Revision history for this message
| Cory Wright (corywright) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Hmm, looks like this might be because of the admittedly missing database
> migration file. Looks like disk_format isn't a column returned from the db
> because the schema hasn't been migrated. Are you using an existing db?
Yes, I was using my existing db. Sorry about that, I'll try again after migrating the db.
> > It would also be nice to be able to specify a particular image to get
> details
> > for instead of having it print all of them. glance details could accept an
> > optional image id.
>
> You mean glance show <ID>? :)
So 'details' is equivalent to 'show' for all images? I would expect 'show' to give basic information on an image, 'details' to give more information on an image such as custom image properties, and something else (showall?) to list everything.
One other nitpick, in the 'show' output is there a good reason to use 'Public?' instead of 'Public:' ? Using colons as the delimiter everywhere would make this output easy to parse in shell scripts and such.