Code review comment for lp:~jaypipes/glance/glance-cli-tool

Revision history for this message
Cory Wright (corywright) wrote :

The 'details' view doesn't appear to be working properly. It finds my 7 images, but only prints details on the first one of them.

  cwright@maverick:~/openstack/glance-cli-tool$ ./bin/glance details
  Found 7 public images...
  ================================================================================
  URI: http://0.0.0.0/images/1
  Id: 1
  Public? Yes
  Name: ramdisk
  Size: 3976716
  Location: file:///home/cwright/openstack/images/glance/1
  'disk_format'
  'disk_format'
  cwright@maverick:~/openstack/glance-cli-tool$

From the code it looks like it should print image properties, but it isn't for one of my images. Also, notice the duplicate 'disk_format' lines in the output.

It would also be nice to be able to specify a particular image to get details for instead of having it print all of them. glance details could accept an optional image id.

review: Needs Fixing

« Back to merge proposal