Code review comment for lp:~jaypipes/glance/glance-cli-tool

Revision history for this message
Sandy Walsh (sandy-walsh) wrote :

Looks great. I thought I'd pass along some things I like in novatools:

1. the use of PrettyTable to make the output look nice. It's a small, flexible package and would remove the need for the '-' * 16 stuff. http://code.google.com/p/prettytable/

2. Novatools goes through great pain to enforce Don't Repeat Yourself (DRY). All of the command line options are decorated so that they produce the --help output and we don't have to run around to update 3-4 different files whenever a command signature changes. It would be great to see that in this client shell as well.

These aren't critical for this merge, but something that would be nice to see for subsequent refactorings.

review: Approve

« Back to merge proposal