Code review comment for lp:~javier.collado/utah/static_analysis_7

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I've got questions! They may reveal gaps in my understanding of proper python programming.

It seems like in some cases, like config.py and client/testsuite.py, docstrings are being changed from
"""
Do a thing.
"""
to
# Do a thing.
But not everywhere. Is there a reason only some of them are coming up?

What's the deal with cls instead of self? Is that something we should be using elsewhere, or is there some reason it only gets changed in the one instance in preseed.py?

How come in provisioning.py we have _stdout and stderr, but in timeout.py we have stdout and _stderr?

Why do a bunch of parameters change to have underscores before them, but not all of them?

Also, lines 120-132 look like a merge conflict.

review: Needs Information

« Back to merge proposal