lp:~javier.collado/utah/static_analysis_7

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:utah at revision 712

Max Brustkern (community): Needs Information on 2012-10-15

Joe Talbott (community): Approve on 2012-10-12

Javier Collado (community): Needs Resubmitting on 2012-10-12

Diff: 465 lines (+80/-54) (has conflicts)

15 files modified

utah/client/common.py (+9/-4)
utah/client/phoenix.py (+3/-1)
utah/client/result.py (+7/-5)
utah/client/runner.py (+9/-1)
utah/client/state_agent.py (+1/-1)
utah/client/testcase.py (+15/-5)
utah/client/tests/manual_privileges.py (+5/-5)
utah/client/testsuite.py (+1/-3)
utah/config.py (+7/-17)
utah/preseed.py (+2/-2)
utah/provisioning/provisioning.py (+4/-4)
utah/provisioning/vm/libvirtvm.py (+4/-2)
utah/run.py (+9/-0)
utah/timeout.py (+3/-3)
utah/url.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

715. By Javier Collado on 2012-10-12

Fixed use hardcoded message by default as suggested by Joe

714. By Javier Collado on 2012-10-12

Fixed use variable, not string ('stdout' -> stdout) as suggested by Joe

713. By Javier Collado on 2012-10-11

Removed object literals as default argument values

This is an issue in python. The default value is initialized just once and will
accumulate any side effect that happens in the function body.

712. By Javier Collado on 2012-10-11

Fixed bad indentation

711. By Javier Collado on 2012-10-11

Replaced relative imports with absolute imports

They are "highly discouraged" in PEP008

710. By Javier Collado on 2012-10-11

Prefixed some unused variables with underscore

pylint likes that convention to make it clear when a variable is intentionally
unused

709. By Javier Collado on 2012-10-11

Changed strings with no effect to comments

708. By Javier Collado on 2012-10-11

Renamed argument variable from `type` to `owner`

This will avoid warnings about redefining built-in `type`

707. By Javier Collado on 2012-10-11

Using cls as first argument to class method instead of self

706. By Javier Collado on 2012-10-11

Merged check return code from vcs get command

Source branch: lp:~joetalbott/utah/vcs_tests_fix