Code review comment for lp:~javier.collado/utah/static_analysis_7
Revision history for this message
| Joe Talbott (joetalbott) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
- There's a bug on line 213 that shouldn't be 'stdout' with quotes which means you shouldn't rename 'stdout' to '_stdout'.
- There's a bug on line 222, that should pass msg into the inner assertion if msg is not None.
- Regarding the relative imports: One of my goals was that the tests and the client be runnable from a local copy of the repository. Can you confirm that both of these cases work as expected with these changes. I am fine with the requirement that both the client and the tests be run from the top-level directory of the branch which means utah resolves to the relative path and doesn't have to be in the python path.