Code review comment for lp:~james-page/ubuntu/natty/xorg-docs/fix-682621

Revision history for this message
Barry Warsaw (barry) wrote :

Hi James, thanks for the contribution to improve Ubuntu!

This looks good to me. I think it's fine to remove availability of the PDF given that the html is still available. I don't have permission to upload your change, but I'll see who I can round up for that.

One warning though: when I tried to build your branch in an schroot, it crashed my machine. I have no idea what happened, and maybe it was just coincidence because when I reboot and rebuilt, everything seemed fine.

review: Approve

« Back to merge proposal