Merge lp:~james-page/ubuntu/natty/xorg-docs/fix-682621 into lp:ubuntu/natty/xorg-docs
Proposed by
James Page
on 2010-11-30
| Status: | Merged |
|---|---|
| Approved by: | Kees Cook on 2010-12-06 |
| Approved revision: | 9 |
| Merged at revision: | 9 |
| Proposed branch: | lp:~james-page/ubuntu/natty/xorg-docs/fix-682621 |
| Merge into: | lp:ubuntu/natty/xorg-docs |
| Diff against target: |
80 lines (+11/-11) 4 files modified
debian/changelog (+9/-0) debian/control (+2/-2) debian/rules (+0/-1) debian/xorg-docs.install (+0/-8) |
| To merge this branch: | bzr merge lp:~james-page/ubuntu/natty/xorg-docs/fix-682621 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kees Cook | 2010-11-30 | Approve on 2010-12-06 | |
| Dave Walker | Approve on 2010-12-03 | ||
| Barry Warsaw (community) | Approve on 2010-12-02 | ||
|
Review via email:
|
|||
Description of the Change
Removed dependency on fop (and generation of pdf documentation) to resolve FTBFS issues due to required dependencies not being in main archive.
HTML documentation is still generated.
To post a comment you must log in.
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi James, thanks for the contribution to improve Ubuntu!
This looks good to me. I think it's fine to remove availability of the PDF given that the html is still available. I don't have permission to upload your change, but I'll see who I can round up for that.
One warning though: when I tried to build your branch in an schroot, it crashed my machine. I have no idea what happened, and maybe it was just coincidence because when I reboot and rebuilt, everything seemed fine.