Merge lp:~james-page/charms/precise/keystone/upgrade-charm-fix into lp:~openstack-charmers/charms/precise/keystone/ha-support
Proposed by
James Page
Status: | Merged |
---|---|
Merged at revision: | 68 |
Proposed branch: | lp:~james-page/charms/precise/keystone/upgrade-charm-fix |
Merge into: | lp:~openstack-charmers/charms/precise/keystone/ha-support |
Diff against target: |
12 lines (+2/-0) 1 file modified
hooks/keystone_hooks.py (+2/-0) |
To merge this branch: | bzr merge lp:~james-page/charms/precise/keystone/upgrade-charm-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Gandelman (community) | Approve | ||
Review via email: mp+162311@code.launchpad.net |
Description of the change
Fixup for upgrade failures
To post a comment you must log in.
Approving, though I'm a bit concerned that the call to utils.install() here might trigger an unintended upgrade of some package that would require user interaction. Eg: A newer keystone package has been published since the install hook was run, apt-get update was run out of band, and upgrade_charm() ends up attempting to install the new keystone, which would require user interaction to deal with modfieid configs. I think we can handle this by fixing utils.install() to only install packages that are not yet installed, instead of installing everything again.