Code review comment for lp:~james-page/charms/precise/keystone/upgrade-charm-fix

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Approving, though I'm a bit concerned that the call to utils.install() here might trigger an unintended upgrade of some package that would require user interaction. Eg: A newer keystone package has been published since the install hook was run, apt-get update was run out of band, and upgrade_charm() ends up attempting to install the new keystone, which would require user interaction to deal with modfieid configs. I think we can handle this by fixing utils.install() to only install packages that are not yet installed, instead of installing everything again.

« Back to merge proposal