Merge lp:~jakedahn/horizon/lp760239 into lp:~hudson-openstack/horizon/trunk

Proposed by Jake Dahn
Status: Superseded
Proposed branch: lp:~jakedahn/horizon/lp760239
Merge into: lp:~hudson-openstack/horizon/trunk
Diff against target: 49 lines (+23/-5)
2 files modified
django-nova/src/django_nova/views/images.py (+3/-0)
openstack-dashboard/dashboard/templates/permission_denied.html (+20/-5)
To merge this branch: bzr merge lp:~jakedahn/horizon/lp760239
Reviewer Review Type Date Requested Status
Devin Carlen Needs Fixing
Review via email: mp+57594@code.launchpad.net

This proposal has been superseded by a proposal from 2011-04-20.

Description of the change

This branch adds styling to the permission denied page.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

10 + 'Permission Denied %s' % e.message)

let's drop the %s and e.message. they are redundant here

review: Needs Fixing
lp:~jakedahn/horizon/lp760239 updated
34. By Jake Dahn

removing redundant error message

35. By Jake Dahn

removing redirect from images view, as it is handled by the @handle_nova_error decorator

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'django-nova/src/django_nova/views/images.py'
--- django-nova/src/django_nova/views/images.py 2011-04-13 19:05:52 +0000
+++ django-nova/src/django_nova/views/images.py 2011-04-20 18:21:33 +0000
@@ -88,6 +88,9 @@
88 except exceptions.NovaApiError, e:88 except exceptions.NovaApiError, e:
89 messages.error(request,89 messages.error(request,
90 'Unable to launch: %s' % e.message)90 'Unable to launch: %s' % e.message)
91 except exceptions.NovaUnauthorizedError, e:
92 messages.error(request, 'Permission Denied')
93 return redirect('dashboard_permission_denied')
91 else:94 else:
92 for instance in reservation.instances:95 for instance in reservation.instances:
93 messages.success(request,96 messages.success(request,
9497
=== modified file 'openstack-dashboard/dashboard/templates/permission_denied.html'
--- openstack-dashboard/dashboard/templates/permission_denied.html 2011-01-12 21:43:31 +0000
+++ openstack-dashboard/dashboard/templates/permission_denied.html 2011-04-20 18:21:33 +0000
@@ -1,11 +1,26 @@
1{% extends "dashboard/base.html" %}1{% extends "base.html" %}
22
3{% block title %} - Permission Denied{% endblock %}3{% block title %} - Permission Denied{% endblock %}
4{% block pageclass %}denied{% endblock %}
54
6{% block content %}5{% block content %}
7 <div id="page_head">6 <div id="right_content">
8 <h2 id="page_heading">Permission Denied</h2>7 <div id="page_head">
9 <p id="page_description">You do not have permission to view the requested page.</p>8 <h2 id="page_heading">Permission Denied</h2>
9 <p id="page_description">You do not have permission to view the requested page.</p>
10 </div>
10 </div>11 </div>
11{% endblock %}12{% endblock %}
13
14{% block sidebar %}
15 <div id="sidebar">
16 <ul id="navigation">
17 {% block nav_home %}
18 <li><h3><a href="/">Home</a></h3></li>
19 {% endblock %}
20
21 {% block nav_projects %}
22 <li><h3><a href="/">Projects</a></h3></li>
23 {% endblock %}
24 </ul>
25 </div> <!-- end sidebar -->
26{% endblock %}

Subscribers

People subscribed via source and target branches