Merge lp:~jakedahn/horizon/lp760239 into lp:~hudson-openstack/horizon/trunk

Proposed by Jake Dahn
Status: Superseded
Proposed branch: lp:~jakedahn/horizon/lp760239
Merge into: lp:~hudson-openstack/horizon/trunk
Diff against target: 49 lines (+23/-5)
2 files modified
django-nova/src/django_nova/views/images.py (+3/-0)
openstack-dashboard/dashboard/templates/permission_denied.html (+20/-5)
To merge this branch: bzr merge lp:~jakedahn/horizon/lp760239
Reviewer Review Type Date Requested Status
Devin Carlen Needs Fixing
Review via email: mp+57594@code.launchpad.net

This proposal has been superseded by a proposal from 2011-04-20.

Description of the change

This branch adds styling to the permission denied page.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

10 + 'Permission Denied %s' % e.message)

let's drop the %s and e.message. they are redundant here

review: Needs Fixing
lp:~jakedahn/horizon/lp760239 updated
34. By Jake Dahn

removing redundant error message

35. By Jake Dahn

removing redirect from images view, as it is handled by the @handle_nova_error decorator

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'django-nova/src/django_nova/views/images.py'
2--- django-nova/src/django_nova/views/images.py 2011-04-13 19:05:52 +0000
3+++ django-nova/src/django_nova/views/images.py 2011-04-20 18:21:33 +0000
4@@ -88,6 +88,9 @@
5 except exceptions.NovaApiError, e:
6 messages.error(request,
7 'Unable to launch: %s' % e.message)
8+ except exceptions.NovaUnauthorizedError, e:
9+ messages.error(request, 'Permission Denied')
10+ return redirect('dashboard_permission_denied')
11 else:
12 for instance in reservation.instances:
13 messages.success(request,
14
15=== modified file 'openstack-dashboard/dashboard/templates/permission_denied.html'
16--- openstack-dashboard/dashboard/templates/permission_denied.html 2011-01-12 21:43:31 +0000
17+++ openstack-dashboard/dashboard/templates/permission_denied.html 2011-04-20 18:21:33 +0000
18@@ -1,11 +1,26 @@
19-{% extends "dashboard/base.html" %}
20+{% extends "base.html" %}
21
22 {% block title %} - Permission Denied{% endblock %}
23-{% block pageclass %}denied{% endblock %}
24
25 {% block content %}
26- <div id="page_head">
27- <h2 id="page_heading">Permission Denied</h2>
28- <p id="page_description">You do not have permission to view the requested page.</p>
29+ <div id="right_content">
30+ <div id="page_head">
31+ <h2 id="page_heading">Permission Denied</h2>
32+ <p id="page_description">You do not have permission to view the requested page.</p>
33+ </div>
34 </div>
35 {% endblock %}
36+
37+{% block sidebar %}
38+ <div id="sidebar">
39+ <ul id="navigation">
40+ {% block nav_home %}
41+ <li><h3><a href="/">Home</a></h3></li>
42+ {% endblock %}
43+
44+ {% block nav_projects %}
45+ <li><h3><a href="/">Projects</a></h3></li>
46+ {% endblock %}
47+ </ul>
48+ </div> <!-- end sidebar -->
49+{% endblock %}

Subscribers

People subscribed via source and target branches