Merge lp:~j-corwin/openlp/presentations into lp:openlp

Proposed by Jonathan Corwin
Status: Merged
Merged at revision: not available
Proposed branch: lp:~j-corwin/openlp/presentations
Merge into: lp:openlp
Diff against target: 26 lines
1 file modified
openlp/plugins/presentations/lib/__init__.py (+8/-4)
To merge this branch: bzr merge lp:~j-corwin/openlp/presentations
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Jon Tibble (community) Approve
Review via email: mp+12370@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jonathan Corwin (j-corwin) wrote :

Not entirely sure about the rules for __init__.py, but these changes get rid of the linux errors.

Revision history for this message
Jon Tibble (meths) wrote :

Looks good.

review: Approve
Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

There should be a blank line between the copyright notice and "import os"

review: Approve
lp:~j-corwin/openlp/presentations updated
569. By Jonathan Corwin

Merge from lp:~j-corwin/openlp/presentations

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/plugins/presentations/lib/__init__.py'
--- openlp/plugins/presentations/lib/__init__.py 2009-09-23 22:39:37 +0000
+++ openlp/plugins/presentations/lib/__init__.py 2009-09-24 18:50:45 +0000
@@ -21,14 +21,18 @@
21# with this program; if not, write to the Free Software Foundation, Inc., 59 #21# with this program; if not, write to the Free Software Foundation, Inc., 59 #
22# Temple Place, Suite 330, Boston, MA 02111-1307 USA #22# Temple Place, Suite 330, Boston, MA 02111-1307 USA #
23###############################################################################23###############################################################################
24import os
2425
25from impresscontroller import ImpressController26from impresscontroller import ImpressController
26#from powerpointcontroller import PowerpointController27if os.name == u'nt':
27from pptviewcontroller import PptviewController28 #from powerpointcontroller import PowerpointController
29 from pptviewcontroller import PptviewController
28from messagelistener import MessageListener30from messagelistener import MessageListener
29from mediaitem import PresentationMediaItem31from mediaitem import PresentationMediaItem
30from presentationtab import PresentationTab32from presentationtab import PresentationTab
3133
32
33__all__ = ['PresentationMediaItem', 'PresentationTab',34__all__ = ['PresentationMediaItem', 'PresentationTab',
34 'ImpressController', 'ImpressController', 'PowerpointController', 'MessageListener']35 'ImpressController', 'MessageListener']
36if os.name == u'nt':
37 __all__.append('PptviewController')
38 #__all__.append('PowerpointController');