Code review comment for lp:~j-4-deactivatedaccount/tomdroid/bugfix-800176

Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

Thanks for reviewing the other stuff! I'll try to keep things more consistent.
I changed the bugfix now. I couldn't push the code into the xml parser - no idea how this should work. But i wrote a function in the Note class and called it from ViewNote and Send.

PS: I wrote the news file and found a misunderstanding. I haven't integrated the search system wide atm, because therefore i would have to remove the search history again and call notes as search suggestions. I don't know which way is better. Maybe i will write both with an option in preferences later.

Ready for review again!

review: Needs Resubmitting

« Back to merge proposal