Merge lp:~j-4-deactivatedaccount/tomdroid/bugfix-800176 into lp:~tomdroid-maintainers/tomdroid/main
Proposed by
Stefan Hammer
Status: | Merged |
---|---|
Approved by: | Olivier Bilodeau |
Approved revision: | 236 |
Merged at revision: | 239 |
Proposed branch: | lp:~j-4-deactivatedaccount/tomdroid/bugfix-800176 |
Merge into: | lp:~tomdroid-maintainers/tomdroid/main |
Diff against target: |
73 lines (+17/-15) 3 files modified
src/org/tomdroid/Note.java (+11/-0) src/org/tomdroid/ui/ViewNote.java (+1/-8) src/org/tomdroid/util/Send.java (+5/-7) |
To merge this branch: | bzr merge lp:~j-4-deactivatedaccount/tomdroid/bugfix-800176 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Bilodeau | Approve | ||
Stefan Hammer (community) | Needs Resubmitting | ||
Review via email:
|
Description of the change
Fix critical Bug #800176.
To post a comment you must log in.
I just realised, that my fix is rather quick and dirty than good.
In ViewNote.java -> showNote() there is a block of code, which does exactly the same.
I could also move this code to Note.java and just call the new method from Send() and showNote().
Maybe we should remove the title from the noteContent string at all in Note.java -> getNoteContent(). Is the title important in the content? This would save a lot of dirty workarounds to get rid of the title.