Merge lp:~izidor/gtg/title into lp:~gtg/gtg/old-trunk
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1192 | ||||
Proposed branch: | lp:~izidor/gtg/title | ||||
Merge into: | lp:~gtg/gtg/old-trunk | ||||
Diff against target: |
111 lines (+32/-20) 3 files modified
CHANGELOG (+1/-0) gtg (+5/-0) scripts/debug.sh (+26/-20) |
||||
To merge this branch: | bzr merge lp:~izidor/gtg/title | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lionel Dricot (community) | Approve | ||
Review via email: mp+109153@code.launchpad.net |
Description of the change
Added option -t to set the title of windows (You can put whatever you want instead of "Getting Things GNOME!" in the titlebar). It is useful when you have opened multiple instances of GTG and want to differentiate between them.
Use case from real life. I do final debug of a new feature. I import my real life data to test and run it. In that moment I have two identical instances of GTG running. If I want to add a new task to my real GTG (oops, found a bug), it is impossible to distinguish between them.
./scripts/debug.sh sets title to "Dev GTG: <name of the dir>" or "Dev GTG: <name of dir> (<name of -s dataset> dataset)". If I am in ~/projects/
I think it is a nifty feature to have.
Just a small comment: I totally agree it can be really useful, but oriented oriented
maybe another way to implement this would be to set a custom title in
the configuration file. That would allow to have development-
customizations while still avoiding to make them visible to users.
That being said, I don't disapprove this particular solution, it's ok
to merge it (since it's buried in the command line options, it won't
be very visible to the user anyway). However I just wanted to point
out that if we'll need more of such kind of development-
features in the future, it would probably be better to avoid adding a
dedicated flag for each one.
On Thu, Jun 7, 2012 at 4:23 PM, Lionel Dricot <email address hidden> wrote: /code.launchpad .net/~izidor/ gtg/title/ +merge/ 109153
> Review: Approve
>
>
> --
> https:/
> You are subscribed to branch lp:gtg.
--
Bertrand Rousseau