GTG

Code review comment for lp:~izidor/gtg/title

Revision history for this message
Bertrand Rousseau (bertrand-rousseau) wrote :

Just a small comment: I totally agree it can be really useful, but
maybe another way to implement this would be to set a custom title in
the configuration file. That would allow to have development-oriented
customizations while still avoiding to make them visible to users.
That being said, I don't disapprove this particular solution, it's ok
to merge it (since it's buried in the command line options, it won't
be very visible to the user anyway). However I just wanted to point
out that if we'll need more of such kind of development-oriented
features in the future, it would probably be better to avoid adding a
dedicated flag for each one.

On Thu, Jun 7, 2012 at 4:23 PM, Lionel Dricot <email address hidden> wrote:
> Review: Approve
>
>
> --
> https://code.launchpad.net/~izidor/gtg/title/+merge/109153
> You are subscribed to branch lp:gtg.

--
Bertrand Rousseau

« Back to merge proposal