Summary: Excellent work! Many thanks for all of this.
I'm not merging it now just in case you want to do it yourself tomorrow (12/30) first thing or have some other little change you'd like to put in. But if you don't merge it I'll go ahead and do it, and will begin adding code I have (like testing stuff) so we can push towards 0.11. We still have cleanups and things to do, but all of that is best done on top of a more functional trunk, which this branch helps LOT with.
Per-commit comments:
-r1264: ok
-r1265: in kernel/ipclusterapp.py, should we output something visible to the user indicating the 4s pause at shutdown? I won't add it myself, as I'm not sure this should go in; most of our output is now via logging, right? Putting this in the log wouldn't be too useful, it would be strictly a convenience for the user.
-r1266: ok, just upstream
-r1267: great, more examples!
-r1268: good, these are changes we'd discussed over the phone.
-r1269: better docs, excellent...
-r1270, 71, 72, 73: this document is stellar, we'd reviewed it already.
Summary: Excellent work! Many thanks for all of this.
I'm not merging it now just in case you want to do it yourself tomorrow (12/30) first thing or have some other little change you'd like to put in. But if you don't merge it I'll go ahead and do it, and will begin adding code I have (like testing stuff) so we can push towards 0.11. We still have cleanups and things to do, but all of that is best done on top of a more functional trunk, which this branch helps LOT with.
Per-commit comments:
-r1264: ok
-r1265: in kernel/ ipclusterapp. py, should we output something visible to the user indicating the 4s pause at shutdown? I won't add it myself, as I'm not sure this should go in; most of our output is now via logging, right? Putting this in the log wouldn't be too useful, it would be strictly a convenience for the user.
-r1266: ok, just upstream
-r1267: great, more examples!
-r1268: good, these are changes we'd discussed over the phone.
-r1269: better docs, excellent...
-r1270, 71, 72, 73: this document is stellar, we'd reviewed it already.