Code review comment for lp:~inspirated/launchpad/implement-Bug-findAttachments

Revision history for this message
Graham Binns (gmb) wrote :

Hi Kamran, sorry for not getting back to you sooner.

I'll take a look at the code now, but it seems from your cover letter that you've not taken into account Bjorn's (and mine, after some thinking) concerns that we simply shouldn't be searching files in a webservice request; it has far too many pitfalls.

I'd like to get Bjorn's input on this too, because I think that whilst your proposed solution obviates some of the problems it doesn't avoid all of them.

« Back to merge proposal