lp:~inspirated/launchpad/implement-Bug-findAttachments

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:launchpad

Robert Collins (community): Abstain on 2010-07-19

Graham Binns (community): Disapprove (code) on 2010-06-21

Björn Tillenius: Pending requested 2010-06-16

Diff: 234 lines (+175/-0)

7 files modified

lib/lp/bugs/configure.zcml (+1/-0)
lib/lp/bugs/interfaces/bug.py (+10/-0)
lib/lp/bugs/model/bug.py (+61/-0)
lib/lp/bugs/tests/test_bug_find_attachment.py (+87/-0)
lib/lp/bugs/tests/testfiles/sample-attachment-lorem.txt (+4/-0)
lib/lp/bugs/tests/testfiles/sample-attachment-repeatchars.txt (+7/-0)
lib/lp/bugs/tests/testfiles/sample-attachment-unicode.txt (+5/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

11021. By Kamran Riaz Khan on 2010-06-17

Minor changes to improve unittest readability.

11020. By Kamran Riaz Khan on 2010-06-17

Removed urllib2 usage in Bug.findAttachments() by opening attachments
directly.

11019. By Kamran Riaz Khan on 2010-06-17

Minor changes to improve code readability.

11018. By Kamran Riaz Khan on 2010-06-17

Use encode('unicode_escape') instead of urllib.quote() for multiline
searches

11017. By Kamran Riaz Khan on 2010-06-16

Changes in Bug.findAttachments():
 * Use Boyer-Moore-Horspool algorithm to search attachments in chunks
 * Fixed unicode and multiline unittests

11016. By Kamran Riaz Khan on 2010-06-16

Added support for multi-line searches in Bug.findAttachments() using
is_encoded parameter

11015. By Kamran Riaz Khan on 2010-06-15

Fixed Bug.findAttachments() to use preferred encoding instead of UTF-8

11014. By Kamran Riaz Khan on 2010-06-15

Changes in Bug.findAttachments():
 * Limited the size of attachments that can be searched to 8 MB
 * Modified searching to go-through attachments line-wise

11013. By Kamran Riaz Khan on 2010-06-15

Fixed unicode searches in Bug.findAttachments()

11012. By Kamran Riaz Khan on 2010-06-15

Added unit tests for Bug.findAttachments() method