Code review comment for lp:~icsergio/openobject-italia/61_imp_withholding_tax

On 10/16/2013 11:48 PM, Sergio Corato wrote:
> I removed dependancies from account_voucher_cash_basis and account_invoice_template (was useful the latter somewhere?)

account_voucher_cash_basis was used to compute the '
allocated_amounts_grouped_by_invoice', specially in cases of write-off.
Don't we need to handle write-off? Will we never have cases of foreign
currency invoices? Cases of discounts at payments?

Moreover, note that if you heavily change a module in a stable version
(like 6.1 or 7.0), you have to consider what will happen when the new
version of the module will be installed on a production database with
the old version in use.