Merge lp:~icsergio/openobject-italia/61_imp_withholding_tax into lp:~openobject-italia-core-devs/openobject-italia/italian-addons-6.1

[Sergio Corato]

A simpler and so more efficient implementation of withholding tax, with the same features of original one.

[Sergio Corato (icsergio)]

Improvement1: this implementation uses tax object's and there's no neeed to type the amount of the tax, as it's calculated.
The payment term has to be set in the tax code, together with the flag on the boolean field "withholding tax".
Improvement2: moreover, the module sets the tax expiration, at the time of payment of the linked invoice, which is the relevant time for the law.

[Lorenzo Battistini (elbati)]

Ciao Sergio.

The functionalities added here seem to me to be present already in the l10n_it_withholding_tax module.
Moreover this implementation doesn't use the account_voucher_cash_basis module, so I suspect it doesn't handle partial payments, exchange rate differences and so on.

Why didn't you improve the l10n_it_withholding_tax module if necessary?

review: Needs Information

[Sergio Corato (icsergio)]

Il 05/10/2013 10:41, Lorenzo Battistini - Agile BG ha scritto:
> Review: Needs Information
>
> Ciao Sergio.
>
> The functionalities added here seem to me to be present already in the l10n_it_withholding_tax module.
> Moreover this implementation doesn't use the account_voucher_cash_basis module, so I suspect it doesn't handle partial payments, exchange rate differences and so on.
>
> Why didn't you improve the l10n_it_withholding_tax module if necessary?
>
Ciao Lorenzo,
is that a real need or only theoretical? I say so because I've never
seen an invoice from a professional with more than 1 payment expiry,
usually at sight, nor is so usual to see an invoice before the payment.

However, I'll give it a try, if possible I'd like to use taxes for this
module.

--
Sergio Corato

IcsTools.it

web : www.icstools.it
skype : sergiocorato
mail : <email address hidden>

[Sergio Corato (icsergio)]

Il 05/10/2013 14:42, Sergio Corato ha scritto:
> Il 05/10/2013 10:41, Lorenzo Battistini - Agile BG ha scritto:
>> Review: Needs Information
>>
>> Ciao Sergio.
>>
>> The functionalities added here seem to me to be present already in the l10n_it_withholding_tax module.
>> Moreover this implementation doesn't use the account_voucher_cash_basis module, so I suspect it doesn't handle partial payments, exchange rate differences and so on.
>>
>> Why didn't you improve the l10n_it_withholding_tax module if necessary?
>>
> Ciao Lorenzo,
> is that a real need or only theoretical? I say so because I've never
> seen an invoice from a professional with more than 1 payment expiry,
> usually at sight, nor is so usual to see an invoice before the payment.
>
> However, I'll give it a try, if possible I'd like to use taxes for this
> module.
>
Hi Lorenzo,
I tried the official module, with account_voucher_cash_basis, and I
found that it create a scheduled payment for every payment of an invoice
with a partial payment (it'd be good), but the amounts are wrong, and it
doesn't work for payment with more expiry dates (does it work correctly
for you?).
Moreover, it doesn't use the tax object, even if it exists, and it's
possible to set an invoice with withholding tax without the correct tax
code.
Finally, I found difficult to try this unusual way of working, because
usually the payment is made before the invoice, and the invoice is only
for the sum paid.
For the currency I haven't got problems in my implementation.
Could you give me more informations about some use cases you refer?
Thanks.

--
Sergio Corato

IcsTools.it

web : www.icstools.it
skype : sergiocorato
mail : <email address hidden>

[Lorenzo Battistini (elbati)]

On 10/07/2013 01:39 AM, Sergio Corato wrote:
>
> Hi Lorenzo,
> I tried the official module, with account_voucher_cash_basis, and I
> found that it create a scheduled payment for every payment of an invoice
> with a partial payment (it'd be good), but the amounts are wrong, and it
> doesn't work for payment with more expiry dates (does it work correctly
> for you?).

In general, it does.

Could you describe the steps to reproduce the problem and report them to
https://bugs.launchpad.net/openobject-italia/+bugs
?

> Moreover, it doesn't use the tax object, even if it exists, and it's
> possible to set an invoice with withholding tax without the correct tax
> code.

At the moment, if you are using 6.1, 'Ritenute d'acconto' tax codes are
deprecated because they were used by the previous version of the module.
OpenERP 7.0 doesn't provide those tax codes.

An implementation that uses tax codes is certainly possible (of course,
you can propose a merge for that).
For now, users know what and when to pay using the due list.

The current implementation is broadly based on this specifications
http://wiki.openerp-italia.org/doku.php/area_utente/requisiti/ritenuta_d_acconto?&#fattura_ricevuta

> Finally, I found difficult to try this unusual way of working, because
> usually the payment is made before the invoice, and the invoice is only
> for the sum paid.
> For the currency I haven't got problems in my implementation.
> Could you give me more informations about some use cases you refer?

We have customers that sometimes pay professionals invoices partially.
I just know that they do. But if you think it's wrong, I can investigate
more.

[lp:~icsergio/openobject-italia/61_imp_withholding_tax]

242. By Sergio Corato on 2013-10-12

[IMP] a more accountant vision of implementation

[Sergio Corato (icsergio)]

Hi Lorenzo,
I commit an implementation based on the official module, I think this would be good for your needs too.
I'll do a video or something to let your know where I've found bugs (or misunderstoods?)

[Sergio Corato (icsergio)]

A bit more information:
- flag the parent tax.code as withholding_type and create a payment term (usually 16 of next month)
- set the withholding journal in the company.

I opened a bug for the official version here: https://bugs.launchpad.net/openobject-italia/+bug/1239216

Here I uploaded a video for this implementation https://vimeo.com/76777965

[lp:~icsergio/openobject-italia/61_imp_withholding_tax]

243. By Sergio Corato on 2013-10-12

[FIX] error description

244. By Sergio Corato on 2013-10-13

[FIX] calculation method

245. By Sergio Corato on 2013-10-13

[FIX] calculation method better comprehension

[Lorenzo Battistini (elbati)]

Hello Sergio.
Could you summarize, in the description, the changes introduced by this MP?
For example, the first improvement
"this implementation uses tax object's and there's no neeed to type the amount of the tax, as it's calculated"
is not valid anymore I think.

Moreover: how can the voucher correctly compute the amount to pay if it doesn't use the 'allocated_amounts_grouped_by_invoice' method? Is it unnecessary? (reference: http://bazaar.launchpad.net/~account-payment-team/account-payment/7.0/view/102/account_voucher_cash_basis/account_voucher.py#L83 )

Thanks!

review: Needs Information

[lp:~icsergio/openobject-italia/61_imp_withholding_tax]

246. By Sergio Corato on 2013-10-16

[FIX] improved formula to support more complex invoices with multiple rows and rows without withholding tax

[Sergio Corato (icsergio)]

Hi Lorenzo,
I did a little improvement, and from some tests it seems working well (with more service lines and no-tax lines too).
The amount are calculated in this way:

amount paid / invoice debit = % paid of debit
* withholding amount = % paid of withholding amount
* withholding rate = withholding amount to pay to tax authorities

[lp:~icsergio/openobject-italia/61_imp_withholding_tax]

247. By Sergio Corato on 2013-10-16

[FIX] improved move line reconcile process

[Sergio Corato (icsergio)]

Ok, now there are no more lines unuseful in payment.

[lp:~icsergio/openobject-italia/61_imp_withholding_tax]

248. By Sergio Corato on 2013-10-16

[FIX] removed unused dependancies

[Sergio Corato (icsergio)]

I removed dependancies from account_voucher_cash_basis and account_invoice_template (was useful the latter somewhere?)

[Lorenzo Battistini (elbati)]

On 10/16/2013 11:48 PM, Sergio Corato wrote:
> I removed dependancies from account_voucher_cash_basis and account_invoice_template (was useful the latter somewhere?)

account_voucher_cash_basis was used to compute the '
allocated_amounts_grouped_by_invoice', specially in cases of write-off.
Don't we need to handle write-off? Will we never have cases of foreign
currency invoices? Cases of discounts at payments?

Moreover, note that if you heavily change a module in a stable version
(like 6.1 or 7.0), you have to consider what will happen when the new
version of the module will be installed on a production database with
the old version in use.

[Lorenzo Battistini (elbati)]

Riporto qui la risposta

Il 17/10/2013 18:36, Lorenzo Battistini - Agile BG ha scritto:
> On 10/16/2013 11:48 PM, Sergio Corato wrote:
>> I removed dependancies from account_voucher_cash_basis and account_invoice_template (was useful the latter somewhere?)
>
> account_voucher_cash_basis was used to compute the '
> allocated_amounts_grouped_by_invoice', specially in cases of write-off.
> Don't we need to handle write-off?
> Cases of discounts at payments?

Are you sure if we have a discount the amount of withholding tax is lowered too? Without having a regular refund invoice?
Anyone can answer to this question?

Anyway, it's a little modification of the code, if needed.

Will we never have cases of foreign
> currency invoices?
Did you try the module? Have you faced some problem?

>
>
> Moreover, note that if you heavily change a module in a stable version
> (like 6.1 or 7.0), you have to consider what will happen when the new
> version of the module will be installed on a production database with
> the old version in use.
Yeah, I know, it's only for -new- databases and an idea for the next releases.
>
>

--
Sergio Corato

[Lorenzo Battistini (elbati)]

"Did you try the module? Have you faced some problem?"

I just tried but can't find how taxes have to be configured in order to be used as withholding tax.
If I use the standard 'rit-20' account.tax, am I supposed to add it to every invoice line subject to withholding tax?

"Yeah, I know, it's only for -new- databases and an idea for the next releases"

So, if installations on existing databases will not be handled, this proposal has to be rejected.
Maybe we could keep the module in a separate branch and merge into official branches at the next version of OpenERP.

[Sergio Corato (icsergio)]

1. Exacly, like VAT. It can be that a row have one withholding tax, another
have another withholding tax, another have more withholding taxes, another
have no withholding tax.
2. Good, it was my objective. I'll link it to trunk serie, then.
Thx

2013/10/18 Lorenzo Battistini - Agile BG <email address hidden>

> "Did you try the module? Have you faced some problem?"
>
> I just tried but can't find how taxes have to be configured in order to be
> used as withholding tax.
> If I use the standard 'rit-20' account.tax, am I supposed to add it to
> every invoice line subject to withholding tax?
>
>
> "Yeah, I know, it's only for -new- databases and an idea for the next
> releases"
>
> So, if installations on existing databases will not be handled, this
> proposal has to be rejected.
> Maybe we could keep the module in a separate branch and merge into
> official branches at the next version of OpenERP.
> --
>
> https://code.launchpad.net/~icsergio/openobject-italia/61_imp_withholding_tax/+merge/189442
> Your team OpenERP Italia core devs is subscribed to branch
> lp:openobject-italia/6.1.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openobject-italia-core-devs
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openobject-italia-core-devs
> More help : https://help.launchpad.net/ListHelp
>

[Lorenzo Battistini (elbati)]

Ciao Sergio,

ho fatto la sequente prova:

 1. Ho creato un nuovo db (6.1 installazione standard) e ho installato
    il nuovo modulo ritenute.
 2. Ho creato una fattura fornitore, come da immagine
    http://img842.imageshack.us/img842/8108/yumg.png
 3. L'ho confermata e ho ottenuto una registrazione come da immagine
    http://img713.imageshack.us/img713/8537/yrg8.png

Vedo che alla conferma della fattura è stato movimentato il conto
'debiti per ritenute da versare' e il conto imposta 'ritenute a debito 20%'.
Dato che le ritenute seguono il criterio di cassa, il debito non
dovrebbe essere aperto solamente al momento del pagamento?

Bisogna configurare diversamente le imposte?

[Lorenzo Battistini (elbati)]

This project is now hosted on https://github.com/OCA/l10n-italy. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Unmerged revisions

248. By Sergio Corato on 2013-10-16

[FIX] removed unused dependancies

247. By Sergio Corato on 2013-10-16

[FIX] improved move line reconcile process

246. By Sergio Corato on 2013-10-16

[FIX] improved formula to support more complex invoices with multiple rows and rows without withholding tax

245. By Sergio Corato on 2013-10-13

[FIX] calculation method better comprehension

244. By Sergio Corato on 2013-10-13

[FIX] calculation method

243. By Sergio Corato on 2013-10-12

[FIX] error description

242. By Sergio Corato on 2013-10-12

[IMP] a more accountant vision of implementation

241. By Sergio Corato on 2013-10-04

[ADD] withholding simpler implementation

=== modified file 'l10n_it_withholding_tax/__openerp__.py'
--- l10n_it_withholding_tax/__openerp__.py	2013-01-04 14:02:10 +0000
+++ l10n_it_withholding_tax/__openerp__.py	2013-10-16 21:46:08 +0000
@@ -22,7 +22,7 @@
 ##############################################################################
 {
     'name': "Italian Localisation - Withholding tax",
-    'version': '0.2',
+    'version': '0.3',
     'category': 'Localisation/Italy',
     'description': """
 Ritenute d'acconto sulle fatture fornitore
@@ -46,9 +46,10 @@
     'author': 'OpenERP Italian Community',
     'website': 'http://www.openerp-italia.org',
     'license': 'AGPL-3',
-    "depends" : ['account_invoice_template', 'account_voucher_cash_basis'],
+    "depends" : ['account_voucher',],
     "init_xml" : [
         'account_view.xml',
+        'tax_view.xml',
         ],
     "update_xml" : [],
     "demo_xml" : [],

=== modified file 'l10n_it_withholding_tax/account.py'
--- l10n_it_withholding_tax/account.py	2013-01-04 14:02:10 +0000
+++ l10n_it_withholding_tax/account.py	2013-10-16 21:46:08 +0000
@@ -23,31 +23,22 @@
 
 from osv import fields, osv
 from tools.translate import _
-import decimal_precision as dp
+
 
 class res_company(osv.osv):
     _inherit = 'res.company'
     _columns = {
-        'withholding_payment_term_id': fields.many2one('account.payment.term', 'Withholding tax Payment Term'),
-        'withholding_account_id': fields.many2one('account.account','Withholding account', help='Payable account used for amount due to tax authority', domain=[('type', '=', 'payable')]),
-        'withholding_journal_id': fields.many2one('account.journal','Withholding journal', help="Journal used for registration of witholding amounts to be paid"),
+        'withholding_journal_id': fields.many2one('account.journal', 'Withholding journal', help="Journal used for registration of witholding amounts to be paid"),
         }
 
-class account_invoice(osv.osv):
-    
-    def _net_pay(self, cr, uid, ids, field_name, arg, context=None):
-        res = {}
-        for invoice in self.browse(cr, uid, ids, context):
-            res[invoice.id] = invoice.amount_total - invoice.withholding_amount
-        return res
-
-    _inherit = "account.invoice"
-
+
+class account_tax(osv.osv):
+    _inherit = 'account.tax.code'
     _columns = {
-        'withholding_amount': fields.float('Withholding amount', digits_compute=dp.get_precision('Account'), readonly=True, states={'draft':[('readonly',False)]}),
-        'has_withholding': fields.boolean('With withholding tax', readonly=True, states={'draft':[('readonly',False)]}),
-        'net_pay': fields.function(_net_pay, string="Net Pay"),
-        }
+        'withholding_type': fields.boolean("Ritenuta d'acconto"),
+        'withholding_payment_term_id': fields.many2one('account.payment.term', "Termine di pagamento ritenuta d'acconto"),
+    }
+
 
 class account_voucher(osv.osv):
     _inherit = "account.voucher"
@@ -55,84 +46,82 @@
     _columns = {
         'withholding_move_ids': fields.many2many('account.move', 'voucher_withholding_move_rel', 'voucher_id', 'move_id', 'Withholding Tax Entries', readonly=True),
         }
-        
+
     def reconcile_withholding_move(self, cr, uid, invoice, wh_move, context=None):
-        line_pool=self.pool.get('account.move.line')
+        line_pool = self.pool.get('account.move.line')
         rec_ids = []
         for inv_move_line in invoice.move_id.line_id:
-            if inv_move_line.account_id.type == 'payable' and not inv_move_line.reconcile_id:
+            if inv_move_line.account_id.type == 'payable' and not inv_move_line.reconcile_id and inv_move_line.tax_code_id.withholding_type:
                 rec_ids.append(inv_move_line.id)
         for wh_line in wh_move.line_id:
-            if wh_line.account_id.type == 'payable' and invoice.company_id.withholding_account_id and invoice.company_id.withholding_account_id.id != wh_line.account_id.id and not wh_line.reconcile_id:
+            if wh_line.account_id.type == 'payable' and not wh_line.reconcile_id and wh_line.debit:
                 rec_ids.append(wh_line.id)
         return line_pool.reconcile_partial(cr, uid, rec_ids, type='auto', context=context)
-    
+
     def action_move_line_create(self, cr, uid, ids, context=None):
-        res = super(account_voucher,self).action_move_line_create(cr, uid, ids, context)
-        inv_pool = self.pool.get('account.invoice')
+        res = super(account_voucher, self).action_move_line_create(cr, uid, ids, context)
         move_pool = self.pool.get('account.move')
-        tax_pool = self.pool.get('account.tax')
         curr_pool = self.pool.get('res.currency')
         term_pool = self.pool.get('account.payment.term')
         for voucher in self.browse(cr, uid, ids, context):
-            amounts_by_invoice = super(account_voucher,self).allocated_amounts_grouped_by_invoice(cr, uid,voucher, context)
-            for inv_id in amounts_by_invoice:
-                invoice = inv_pool.browse(cr, uid, inv_id, context)
-                if invoice.withholding_amount:
-                    # only for supplier payments
-                    if voucher.type != 'payment':
-                        raise osv.except_osv(_('Error'), _('Can\'t handle withholding tax with voucher of type other than payment'))
-                    if not invoice.company_id.withholding_account_id:
-                        raise osv.except_osv(_('Error'), _('The company does not have an associated Withholding account') )
-                    if not invoice.company_id.withholding_payment_term_id:
-                        raise osv.except_osv(_('Error'), _('The company does not have an associated Withholding Payment Term') )
-                    if not invoice.company_id.withholding_journal_id:
-                        raise osv.except_osv(_('Error'), _('The company does not have an associated Withholding journal') )
-                    # compute the new amount proportionally to paid amount
-                    new_line_amount = curr_pool.round(cr, uid, voucher.company_id.currency_id, ((amounts_by_invoice[invoice.id]['allocated'] + amounts_by_invoice[invoice.id]['write-off']) / invoice.net_pay) * invoice.withholding_amount)
-                    
-                    # compute the due date
-                    due_list = term_pool.compute(
-                        cr, uid, invoice.company_id.withholding_payment_term_id.id, new_line_amount,
-                        date_ref=voucher.date or invoice.date_invoice, context=context)
-                    if len(due_list) > 1:
-                        raise osv.except_osv(_('Error'),
-                            _('The payment term %s has too many due dates')
-                            % invoice.company_id.withholding_payment_term_id.name)
-                    if len(due_list) == 0:
-                        raise osv.except_osv(_('Error'),
-                            _('The payment term %s does not have due dates')
-                            % invoice.company_id.withholding_payment_term_id.name)
-                            
-                    new_move = {
-                        'journal_id': invoice.company_id.withholding_journal_id.id,
-                        'line_id': [
-                            (0,0,{
-                                'name': invoice.number,
-                                'account_id': invoice.account_id.id,
-                                'debit': new_line_amount,
-                                'credit': 0.0,
-                                }),
-                            (0,0,{
-                                'name': _('Payable withholding - ') + invoice.number,
-                                'account_id': invoice.company_id.withholding_account_id.id,
-                                'debit': 0.0,
-                                'credit': new_line_amount,
-                                'date_maturity': due_list[0][0],
-                                }),
-                            ]
-                        }
-                    move_id = self.pool.get('account.move').create(cr, uid, new_move, context=context)
-                    self.reconcile_withholding_move(cr, uid, invoice, move_pool.browse(cr, uid, move_id, context), context)
-                    voucher.write({'withholding_move_ids': [(4, move_id)]})
+            for line in voucher.line_ids:
+                if line.amount and line.move_line_id and line.move_line_id.invoice and not line.move_line_id.tax_code_id.id:
+                    invoice = line.move_line_id.invoice
+                    for inv_tax_line in line.move_line_id.invoice.invoice_line:
+                        for tax_line in inv_tax_line.invoice_line_tax_id:
+                            if tax_line.tax_code_id.withholding_type:
+                                if voucher.type != 'payment':
+                                    raise osv.except_osv(_('Error'), _('Can\'t handle withholding tax with voucher of type other than payment'))
+                                if not tax_line.tax_code_id.withholding_payment_term_id:
+                                    raise osv.except_osv(_('Error'), _('The tax does not have an associated Withholding Payment Term'))
+                                if not invoice.company_id.withholding_journal_id:
+                                    raise osv.except_osv(_('Error'), _('The company does not have an associated Withholding journal'))
+                                due_list = term_pool.compute(
+                                    cr, uid, tax_line.tax_code_id.withholding_payment_term_id.id, line.amount,
+                                    date_ref=voucher.date or invoice.date_invoice, context=context)
+                                if len(due_list) > 1:
+                                    raise osv.except_osv(
+                                        _('Error'),
+                                        _('The payment term %s has too many due dates')
+                                        % tax_line.tax_code_id.withholding_payment_term_id.name)
+                                if len(due_list) == 0:
+                                    raise osv.except_osv(
+                                        _('Error'),
+                                        _('The payment term %s does not have due dates')
+                                        % tax_line.tax_code_id.withholding_payment_term_id.name)
+                                # compute the amount of withholding tax to pay, proportionally to paid amount
+                                new_line_amount = curr_pool.round(cr, uid, voucher.company_id.currency_id, (
+                                 line.amount/invoice.amount_total * inv_tax_line.price_subtotal * - tax_line.amount)
+                                 )
+                                new_move = {
+                                    'journal_id': invoice.company_id.withholding_journal_id.id,
+                                    'line_id': [
+                                        (0, 0, {
+                                            'name': _('Giro contabile ritenuta acconto - ') + invoice.number,
+                                            'account_id': tax_line.account_collected_id.id,
+                                            'debit': new_line_amount,
+                                            'credit': 0.0,
+                                            }),
+                                        (0, 0, {
+                                            'name': _('Giro contabile ritenuta acconto - ') + invoice.number,
+                                            'account_id': tax_line.account_collected_id.id,
+                                            'debit': 0.0,
+                                            'credit': new_line_amount,
+                                            'date_maturity': due_list[0][0],
+                                            'partner_id': invoice.partner_id.id,
+                                            }),
+                                        ]
+                                    }
+                                move_id = self.pool.get('account.move').create(cr, uid, new_move, context=context)
+                                self.reconcile_withholding_move(
+                                    cr, uid, invoice, move_pool.browse(cr, uid, move_id, context), context)
+                                voucher.write({'withholding_move_ids': [(4, move_id)]})
         return res
 
     def cancel_voucher(self, cr, uid, ids, context=None):
-        res = super(account_voucher,self).cancel_voucher(cr, uid, ids, context)
-        reconcile_pool = self.pool.get('account.move.reconcile')
+        res = super(account_voucher, self).cancel_voucher(cr, uid, ids, context)
         move_pool = self.pool.get('account.move')
         for voucher in self.browse(cr, uid, ids, context=context):
-            recs = []
             for move in voucher.withholding_move_ids:
                 move_pool.button_cancel(cr, uid, [move.id])
                 move_pool.unlink(cr, uid, [move.id])

=== modified file 'l10n_it_withholding_tax/account_view.xml'
--- l10n_it_withholding_tax/account_view.xml	2012-10-26 12:17:14 +0000
+++ l10n_it_withholding_tax/account_view.xml	2013-10-16 21:46:08 +0000
@@ -12,46 +12,12 @@
             <field name="arch" type="xml">
                 <field name="paypal_account" position="after">
                     <separator colspan="4"></separator>
-                    <field name="withholding_payment_term_id"/>
-                    <field name="withholding_account_id"/>
                     <field name="withholding_journal_id" />
                     <separator colspan="4"></separator>
                 </field>
             </field>
         </record>
         
-        <!-- invoice -->
-        
-        <record id="invoice_supplier_form" model="ir.ui.view">
-            <field name="name">account.invoice.supplier.form</field>
-            <field name="model">account.invoice</field>
-            <field name="type">form</field>
-            <field name="inherit_id" ref="account.invoice_supplier_form"/>
-            <field name="arch" type="xml">
-                <field name="date_due" position="after">
-                    <field name="has_withholding"/>
-                </field>
-                <field name="amount_total" position="after">
-                    <field name="withholding_amount" attrs="{'invisible': [('has_withholding', '=', False)]}"/>
-                    <field name="net_pay" attrs="{'invisible': [('has_withholding', '=', False)]}"/>
-                </field>
-            </field>
-        </record>
-        
-        <!-- voucher -->
-        
-        <record id="view_vendor_payment_form_wh_move" model="ir.ui.view">
-            <field name="name">account.voucher.payment.form.wh.move</field>
-            <field name="model">account.voucher</field>
-            <field name="type">form</field>
-            <field name="inherit_id" ref="account_voucher.view_vendor_payment_form"/>
-            <field name="arch" type="xml">
-                <field name="move_ids" position="after">
-                    <separator string="Withholding tax entries" colspan="4"></separator>
-                    <field name="withholding_move_ids" colspan="4" nolabel="1"/>
-                </field>
-            </field>
-        </record>
-        
+
     </data>
 </openerp>

=== added file 'l10n_it_withholding_tax/tax_view.xml'
--- l10n_it_withholding_tax/tax_view.xml	1970-01-01 00:00:00 +0000
+++ l10n_it_withholding_tax/tax_view.xml	2013-10-16 21:46:08 +0000
@@ -0,0 +1,18 @@
+<?xml version="1.0" ?>
+<openerp>
+    <data>
+
+        <record id="view_tax_code_form_whtax" model="ir.ui.view">
+            <field name="name">account.tax.code.form</field>
+            <field name="model">account.tax.code</field>
+            <field name="inherit_id" ref="account.view_tax_code_form"/>
+            <field name="arch" type="xml">
+                    <field name="parent_id" position="after">
+                        <field name="withholding_type"/>
+                        <field name="withholding_payment_term_id"/>
+                    </field>
+            </field>
+        </record>
+
+    </data>
+</openerp>