Merge ~hyask/autopkgtest-cloud:skia/fix_push-amqp into autopkgtest-cloud:master

Proposed by Skia
Status: Merged
Merged at revision: c8753f23cf45b58d472e1d5e3a6ad64253eeb9b2
Proposed branch: ~hyask/autopkgtest-cloud:skia/fix_push-amqp
Merge into: autopkgtest-cloud:master
Diff against target: 24 lines (+3/-3)
1 file modified
charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/push-amqp (+3/-3)
Reviewer Review Type Date Requested Status
Tim Andersson Approve
Review via email: mp+464402@code.launchpad.net

Description of the change

I may have missed those two things when backporting the cowboy to `master` in the last "fix push-amqp" MP.

To post a comment you must log in.
Revision history for this message
Tim Andersson (andersson123) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/push-amqp b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/push-amqp
index 5e5ae94..80f70e2 100755
--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/push-amqp
+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/push-amqp
@@ -83,7 +83,9 @@ def main():
83 else:83 else:
84 while True:84 while True:
85 message = sys.stdin.readline()85 message = sys.stdin.readline()
86 if message.startswith("b'") and message.endswith("'"):86 if not message:
87 break
88 if message.startswith("b'") and message.endswith("'\n"):
87 # this is most likely bytes that we need to interpret as a string89 # this is most likely bytes that we need to interpret as a string
88 # `literal_eval` is far safer than a true `eval`: the warnings90 # `literal_eval` is far safer than a true `eval`: the warnings
89 # around it in the documentation mostly mention denial of91 # around it in the documentation mostly mention denial of
@@ -99,8 +101,6 @@ def main():
99 file=sys.stderr,101 file=sys.stderr,
100 )102 )
101 continue103 continue
102 if not message:
103 break
104 try:104 try:
105 push(message, queue_name, ch)105 push(message, queue_name, ch)
106 except (106 except (

Subscribers

People subscribed via source and target branches