Code review comment for ~hyask/autopkgtest-cloud:skia/package_link

Revision history for this message
Tim Andersson (andersson123) wrote :

One "Needs fixing":
- I think the first commit message, "helper" isn't too clear. Change to "helpers" and also mention the commit affects tests.py - It's not exactly a helper function we use in the actual infra so I think that should be specified, otherwise the commit message isn't exactly descriptive of the change

One "Nice to have":
- Is there a way for us to check if a "generic" launchpad url like [1] is valid for a specified package and only add the hyperlink if the page is valid? I just think even though it makes the change a bit more complicated, why not add it now if we can :P

[1] https://bugs.launchpad.net/auto-package-testing

review: Needs Fixing

« Back to merge proposal