Merge ~hyask/autopkgtest-cloud:skia/package_link into autopkgtest-cloud:master
Proposed by
Skia
Status: | Merged |
---|---|
Merged at revision: | 89bec7a60a6896da56562d1ca0c83f3e6a2c4f34 |
Proposed branch: | ~hyask/autopkgtest-cloud:skia/package_link |
Merge into: | autopkgtest-cloud:master |
Diff against target: |
76 lines (+24/-0) 4 files modified
charms/focal/autopkgtest-web/webcontrol/helpers/tests.py (+2/-0) charms/focal/autopkgtest-web/webcontrol/templates/browse-package.html (+3/-0) charms/focal/autopkgtest-web/webcontrol/templates/browse-results.html (+5/-0) charms/focal/autopkgtest-web/webcontrol/templates/macros.html (+14/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Andersson | Approve | ||
Review via email: mp+461440@code.launchpad.net |
To post a comment you must log in.
One "Needs fixing":
- I think the first commit message, "helper" isn't too clear. Change to "helpers" and also mention the commit affects tests.py - It's not exactly a helper function we use in the actual infra so I think that should be specified, otherwise the commit message isn't exactly descriptive of the change
One "Nice to have":
- Is there a way for us to check if a "generic" launchpad url like [1] is valid for a specified package and only add the hyperlink if the page is valid? I just think even though it makes the change a bit more complicated, why not add it now if we can :P
[1] https:/ /bugs.launchpad .net/auto- package- testing