Code review comment for lp:~huwshimi/launchpad/hover-row-43231

Revision history for this message
Martin Pool (mbp) wrote :

I'll just note there is already a hover that produces an underline on
the link to the bug itself (or whatever). I feel it is an antipattern
to have a hover highlight region that is larger than the actually
sensitive region, and this patch would do that. (hraspace is a very
good example of why this is bad.) It's true that the bugzilla theme
cited as an example in the bug does have the same behaviour but I'm
not sure I like it there.

The general skin of Launchpad has changed since this bug was
originally filed, so assertions made then about usability aren't
necessarily true. Personally I feel the dotted lines between rows
give good unity without being as heavy as a hover highlight. Are
there still people who feel otherwise? Unless this actually aids
usability I think we should leave it out.

« Back to merge proposal